Devicetree
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Kurt Borja" <kuurtb@gmail.com>, "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/7] dt-bindings: iio: adc: Add TI ADS126x ADC family
Date: Wed, 1 Jul 2026 01:28:42 +0100	[thread overview]
Message-ID: <20260701012842.16272045@jic23-huawei> (raw)
In-Reply-To: <2a0a9fe9-b3b5-49a0-bf58-5035655fc16d@baylibre.com>

On Tue, 30 Jun 2026 13:38:30 -0500
David Lechner <dlechner@baylibre.com> wrote:

> On 6/30/26 12:14 PM, Kurt Borja wrote:
> > On Mon Jun 29, 2026 at 11:43 AM -05, David Lechner wrote:  
> >> On 6/29/26 11:27 AM, Kurt Borja wrote:  
> >>> On Mon Jun 29, 2026 at 9:21 AM -05, David Lechner wrote:  
> >>>> On 6/28/26 2:12 PM, Kurt Borja wrote:  
> >>>>> On Sun Jun 28, 2026 at 10:45 AM -05, David Lechner wrote:  
> >>>>>> On 6/28/26 12:36 AM, Kurt Borja wrote:  
> >>>>>>> The ADS1262 and ADS1263 are 32-bit, 38.4-kSPS delta-sigma ADCs with an
> >>>>>>> integrated PGA, internal reference, excitation and burn-out current
> >>>>>>> sources for sensor biasing and diagnostics. The ADS1263 adds a second,
> >>>>>>> 24-bit delta-sigma ADC (ADC2) for background measurements.
> >>>>>>>  
> >>>>
> >>>> ...
> >>>>  
> >>>>>>> +
> >>>>>>> +patternProperties:
> >>>>>>> +  "^channel@[0-9]+$":
> >>>>>>> +    $ref: /schemas/iio/adc/adc.yaml#
> >>>>>>> +    unevaluatedProperties: false
> >>>>>>> +
> >>>>>>> +    properties:
> >>>>>>> +      reg:
> >>>>>>> +        maxItems: 1
> >>>>>>> +  
> >>>>>>
> >>>>>> If we want to allow single-ended/pseudo-differential inputs, then we should
> >>>>>> also allow single-channel (positive pin) and common-mode-channel (negative
> >>>>>> pin) properties.
> >>>>>>
> >>>>>> This will also require additional common-mode-<N>-supply properties to allow
> >>>>>> for the negative pin connected to something other than GND.  
> >>>>>
> >>>>> Ah interesting. Why the N though? wouldn't a single supply connected to
> >>>>> AINCOM be enough here?  
> >>>>
> >>>> In theory, any AINx could be a common mode input by connecting it to
> >>>> a constant voltage supply.  
> >>>
> >>> Technically yes, but there is a pin named AINCOM intended for this
> >>> purpose. Can we do a simplification here? I propose having
> >>>
> >>>   common-mode-channel:
> >>>     /* AINCOM pin */
> >>>     const: 10
> >>>
> >>> That way we would only need one common-mode-supply. Would that be okay?
> >>>  
> >>
> >> Ideally, we shouldn't limit how the chip can be wired up in the devicetree
> >> bindings. It doesn't mean that we have to implement everything in the driver
> >> though.  

I'm a bit confused on this.  Arguably you could wire up any side of a differential
pair to a common mode signal, but we haven't had this binding applied more generally
than cases where their is a setup where the intent is a shared common (shielding
on cable in some cases IIRC). 

So why is this case special? I see AIN_COM can be wired up to an internal vbias
but other than that it looks like any other AINX input.

Jonathan

> > 
> > Makes sense.
> > 
> > I just have a doubt: In the ADS112c14 bindings, is there a specific
> > reason why you didn't describe common-mode-<N>-supply?
> >   
> 
> For singled-ended inputs on ADS112c14, there is an internal
> connection to GND, so it isn't possible to have a pseudo-
> differential input like that. I guess technically, it could
> still be possible, but wasn't a typical wiring described in
> the datasheet like it is on ADS1263.
> 


  reply	other threads:[~2026-07-01  0:28 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-28  5:36 [PATCH v2 0/7] iio: adc: Add TI ADS126X ADC family support Kurt Borja
2026-06-28  5:36 ` [PATCH v2 1/7] dt-bindings: iio: adc: Add TI ADS126x ADC family Kurt Borja
2026-06-28 15:45   ` David Lechner
2026-06-28 19:12     ` Kurt Borja
2026-06-29 14:21       ` David Lechner
2026-06-29 16:27         ` Kurt Borja
2026-06-29 16:43           ` David Lechner
2026-06-30 17:14             ` Kurt Borja
2026-06-30 18:38               ` David Lechner
2026-07-01  0:28                 ` Jonathan Cameron [this message]
2026-06-28  5:36 ` [PATCH v2 2/7] iio: adc: Add ti-ads1262 driver Kurt Borja
2026-06-28 17:15   ` David Lechner
2026-06-28 20:00     ` Kurt Borja
2026-06-29 14:38       ` David Lechner
2026-06-30  0:32         ` Jonathan Cameron
2026-06-30 17:17           ` Kurt Borja
2026-06-30  0:28     ` Jonathan Cameron
2026-06-30  0:43   ` Jonathan Cameron
2026-06-28  5:36 ` [PATCH v2 3/7] iio: adc: ti-ads1262: Add channel filter support Kurt Borja
2026-06-28  5:36 ` [PATCH v2 4/7] iio: adc: ti-ads1262: Add excitation current support Kurt Borja
2026-06-30  0:47   ` Jonathan Cameron
2026-06-30 17:18     ` Kurt Borja
2026-06-28  5:36 ` [PATCH v2 5/7] iio: adc: ti-ads1262: Add conversion delay support Kurt Borja
2026-06-30  0:50   ` Jonathan Cameron
2026-06-30 17:23     ` Kurt Borja
2026-06-30 18:44       ` David Lechner
2026-07-01  0:20         ` Jonathan Cameron
2026-06-28  5:36 ` [PATCH v2 6/7] iio: adc: ti-ads1262: Add buffer and trigger support Kurt Borja
2026-06-30  0:54   ` Jonathan Cameron
2026-06-28  5:36 ` [PATCH v2 7/7] iio: adc: Add ti-ads1263-adc2 driver Kurt Borja
2026-06-28 17:22   ` David Lechner
2026-06-28 20:08     ` Kurt Borja
2026-06-29 16:38       ` David Lechner
2026-06-30  1:00         ` Jonathan Cameron
2026-06-30 17:57           ` Kurt Borja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260701012842.16272045@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuurtb@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox