Re: [PATCH 5/7] arm64: dts: mediatek: mt8188: Add and use UART AP_DMA controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The apdma device node is placed out of order based on its unit-address.
--

commit abad4b5e77dac5657d316ab360e0ca880d69701b
Author: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

arm64: dts: mediatek: mt8188: Add and use UART AP_DMA controller

This commit adds the UART DMA controller (AP_DMA) to the MT8188 SoC.
It also assigns the respective DMA channels to the four UART controllers
to improve data transmission and reception efficiency.

> diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> index 75133794cec38..8f01d95e6d7d9 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> @@ -1338,6 +1338,31 @@ systimer: timer@10017000 {
>  			clocks = <&clk13m>;
>  		};
>  
> +		apdma: dma-controller@10220880 {

[Severity: Low]
This isn't a bug, but should this node be placed further down in the file
to maintain ascending unit-address order?

The unit-address 10220880 is placed here after timer@10017000 but before
pwrap@10024000 (shown below), which breaks the numerical sorting convention
for Device Tree nodes.

> +			compatible = "mediatek,mt8188-uart-dma", "mediatek,mt6835-uart-dma";

[ ... ]

> +			#dma-cells = <1>;
> +			dma-requests = <12>;
> +		};
> +
>  		pwrap: pwrap@10024000 {
>  			compatible = "mediatek,mt8188-pwrap", "mediatek,mt8195-pwrap", "syscon";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701121929.19374-1-angelogioacchino.delregno@collabora.com?part=5