Re: [PATCH 2/3] dt-bindings: firmware: add mbedtee,rpc binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing `maxItems` constraint for the `interrupts` property.
--

commit ad51309fadfb753784caac099277a6b19357c757
Author: Xing Loong <xing.xl.loong@gmail.com>

dt-bindings: firmware: add mbedtee,rpc binding

This commit adds the YAML devicetree binding for the MbedTEE Trusted Execution
Environment driver. It describes the shared-memory regions used for RPC
communication between the Linux REE driver and MbedTEE OS on ARM/AArch64 and
RISC-V platforms.

> diff --git a/Documentation/devicetree/bindings/firmware/mbedtee,rpc.yaml b/Documentation/devicetree/bindings/firmware/mbedtee,rpc.yaml
> new file mode 100644
> index 0000000000000..08ae255d32c2a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/firmware/mbedtee,rpc.yaml

[ ... ]

> +properties:
> +  $nodename:
> +    const: mbedtee
> +
> +  compatible:
> +    const: mbedtee,rpc
> +
> +  interrupts:
> +    description:
> +      GIC interrupt used by the TEE to notify the REE of pending RPC
> +      responses (ARM/AArch64 only). Not present on RISC-V platforms which
> +      use IMSIC platform MSI interrupts allocated dynamically at runtime.

[Severity: Low]
Does this property need a maxItems constraint? 

Without maxItems: 1, device tree validation will not catch configurations that
accidentally supply multiple interrupts.

> +
> +  msi-parent:
> +    maxItems: 1
> +    description:
> +      IMSIC MSI controller used by the Linux driver to allocate the

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701132514.186953-1-xing.xl.loong@gmail.com?part=2