Re: [PATCH v2 2/3] dt-bindings: firmware: add mbedtee,tee binding

[Krzysztof Kozlowski <krzk@kernel.org>]

On 02/07/2026 17:11, Xing Loong wrote:
> +
> +  On RISC-V the TEE signals the REE via IMSIC MSI; the REE submits
> +  commands via r2t-ring that the TEE polls. No REE-to-TEE interrupt
> +  is used. No SBI ecall is involved.
> +
> +properties:
> +  compatible:
> +    const: mbedtee,tee


No, you need to respond to feedback instead of sending the same code
called v2. You received comments for a reason. Sending v2 now hides all
this comments and people might think discussion is resolved. This is
very bad practice.

Also,
Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets. See also:
https://elixir.bootlin.com/linux/v6.16-rc2/source/Documentation/process/submitting-patches.rst#L830

...

> +
> +examples:
> +  - |
> +    /* ARM TrustZone (SMC) */
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    firmware {
> +      mbedtee {
> +        compatible = "mbedtee,tee";
> +        interrupts = <GIC_SPI 72 IRQ_TYPE_EDGE_RISING>;
> +        memory-region = <&mbedtee_t2r_ring>, <&mbedtee_t2r_shm>;
> +        memory-region-names = "t2r-ring", "t2r-shm";
> +      };
> +    };
> +
> +    /* memory-region phandle targets */
> +    mbedtee_t2r_ring: t2r-ring {};
> +    mbedtee_t2r_shm: t2r-shm {};

I asked you to drop all these irrelevant entries.

> +
> +  - |
> +    /* RISC-V IMSIC (ring-buffer polling REE->TEE, MSI TEE->REE) */
> +
> +    firmware {
> +      mbedtee {
> +        compatible = "mbedtee,tee";
> +        msi-parent = <&imsic>;
> +        memory-region = <&rv_t2r_ring>, <&rv_t2r_shm>,
> +                        <&rv_r2t_ring>;
> +        memory-region-names = "t2r-ring", "t2r-shm",
> +                              "r2t-ring";
> +      };
> +    };
> +
> +    /* msi-parent phandle target */
> +    imsic: imsic {
> +      msi-controller;
> +      #msi-cells = <0>;
> +    };

Also drop.

> +
> +    /* memory-region phandle targets */
> +    rv_t2r_ring: t2r-ring {};
> +    rv_t2r_shm: t2r-shm {};
> +    rv_r2t_ring: r2t-ring {};

Also not relevant.

I will not continue the review. Please go back to v1 and continue the
discussion.

I consider this version NAKed.


Best regards,
Krzysztof