Re: [PATCH] ARM: dts: am33xx: avoid invalid OCP device-link for timer1 and timer2

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Using the undocumented, Linux-internal `post-init-providers` property to silence an OS warning.
--

commit be227235cebc7285a11a56bcbf6975ef2b78f927
Author: Wagner Popov dos Santos <wpopov@gmail.com>
ARM: dts: am33xx: avoid invalid OCP device-link for timer1 and timer2

This patch updates dependency handling for timer1 and timer2 on AM335x/UCC3.
It adds post-init-providers to the device nodes to avoid boot-time
fw_devlink errors caused by invalid link-creation attempts.

> diff --git a/arch/arm/boot/dts/ti/omap/am33xx.dtsi b/arch/arm/boot/dts/ti/omap/am33xx.dtsi
> index ca3e7f5d7d0dc..760598d5ae1c9 100644
> --- a/arch/arm/boot/dts/ti/omap/am33xx.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/am33xx.dtsi
> @@ -708,6 +708,7 @@ &timer1_target {
>  	timer@0 {
>  		assigned-clocks = <&timer1_fck>;
>  		assigned-clock-parents = <&sys_clkin_ck>;
> +		post-init-providers = <&ocp>;

[Severity: Medium]
Does this introduce a regression by using an undocumented Linux-specific
property in the Device Tree to silence an OS warning here in timer1_target?

Since Device Tree is intended to be an OS-agnostic hardware description,
adding this internal Linux fw_devlink mechanism pollutes the DT with an
OS-specific probing workaround.

Would it be better to fix this regression in the driver core instead?

Perhaps patching fw_devlink_create_devlink() to gracefully skip link creation
when the resolved supplier is an ancestor of the consumer would address the
root cause without adding OS-specific properties to the DT.

>  	};
>  };
>  
> @@ -721,5 +722,6 @@ &timer2_target {
>  	timer@0 {
>  		assigned-clocks = <&timer2_fck>;
>  		assigned-clock-parents = <&sys_clkin_ck>;
> +		post-init-providers = <&ocp>;

[Severity: Medium]
Does this node for timer2_target introduce the same regression mentioned
above?

>  	};
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701175647.8694-1-wpopov@gmail.com?part=1