Re: [PATCH 2/2] dt-bindings: arm: omap: Convert IVA to DT schema

[Krzysztof Kozlowski <krzk@kernel.org>]

On Tue, Jun 30, 2026 at 01:28:56PM +0000, Eduard Bostina wrote:
> Convert the Texas Instruments IVA bindings to DT schema.
> 
> During the conversion, several updates were made to reflect actual hardware
> usage and resolve dtbs_check warnings:
>  - Added a dsp sub node that references the new ti,omap3-c64.yaml
> schema to support OMAP3 configurations where the DSP is defined as a
> child of the IVA node.
>  - Updated the compatible property to allow ti,ivahd as a standalone
> string.

Heh? Old binding already said that, so you did not implement such
change. Instead you invented ti,iva without a reason...

>  - ti,hwmods has been made optional.

Why?

>  - Added a second example to demonstrate the OMAP3 configuration
> with the nested DSP node.
> 
> Signed-off-by: Eduard Bostina <egbostina@gmail.com>
> ---
>  .../devicetree/bindings/arm/omap/iva.txt      | 19 -------
>  .../devicetree/bindings/arm/omap/ti,iva.yaml  | 51 +++++++++++++++++++
>  2 files changed, 51 insertions(+), 19 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/arm/omap/iva.txt
>  create mode 100644 Documentation/devicetree/bindings/arm/omap/ti,iva.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/omap/iva.txt b/Documentation/devicetree/bindings/arm/omap/iva.txt
> deleted file mode 100644
> index 6d6295171358..000000000000
> --- a/Documentation/devicetree/bindings/arm/omap/iva.txt
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -* TI - IVA (Imaging and Video Accelerator) subsystem
> -
> -The IVA contain various audio, video or imaging HW accelerator
> -depending of the version.
> -
> -Required properties:
> -- compatible : Should be:
> -  - "ti,ivahd" for OMAP4
> -  - "ti,iva2.2" for OMAP3
> -  - "ti,iva2.1" for OMAP2430
> -  - "ti,iva1" for OMAP2420
> -- ti,hwmods: "iva"
> -
> -Examples:
> -
> -iva {
> -    compatible = "ti,ivahd", "ti,iva";
> -    ti,hwmods = "iva";
> -};
> diff --git a/Documentation/devicetree/bindings/arm/omap/ti,iva.yaml b/Documentation/devicetree/bindings/arm/omap/ti,iva.yaml
> new file mode 100644
> index 000000000000..771415196235
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/omap/ti,iva.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/omap/ti,iva.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments IVA (Imaging and Video Accelerator)
> +
> +maintainers:
> +  - Eduard Bostina <egbostina@gmail.com>
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - const: ti,ivahd
> +          - const: ti,iva

From where did you get such list (ti,iva fallback)? ti,iva is completely
undocumented and completely unused (not existing), so why it did come up
with it?

> +      - enum:
> +          - ti,iva1
> +          - ti,iva2.1
> +          - ti,iva2.2
> +          - ti,ivahd

This is wrong. ti,ivahd cannot be both: compatible and not compatible
with ti,iva

> +
> +  ti,hwmods:
> +    description: Name of the hwmod associated to the iva
> +    $ref: /schemas/types.yaml#/definitions/string

And here it is a string. Confusing.

> +    const: iva
> +
> +  dsp:
> +    type: object
> +    $ref: /schemas/arm/omap/ti,omap3-c64.yaml#

Missing unevaluatedProperties: false.

Actually the other binding could be squashed/folded into this place...
but split is fine as well.

> +
> +required:
> +  - compatible
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    iva {
> +        compatible = "ti,iva2.2";
> +        ti,hwmods = "iva";
> +        dsp {
> +            compatible = "ti,omap3-c64";
> +        };
> +    };
> +  - |
> +    iva {
> +        compatible = "ti,ivahd", "ti,iva";
> +        ti,hwmods = "iva";
> +    };
> -- 
> 2.43.0
>