* [PATCH 0/2] dt-bindings: arm: omap: Convert DSP and IVA bindings to DT schema @ 2026-06-30 13:28 Eduard Bostina 2026-06-30 13:28 ` [PATCH 1/2] dt-bindings: arm: omap: Convert DSP " Eduard Bostina 2026-06-30 13:28 ` [PATCH 2/2] dt-bindings: arm: omap: Convert IVA " Eduard Bostina 0 siblings, 2 replies; 8+ messages in thread From: Eduard Bostina @ 2026-06-30 13:28 UTC (permalink / raw) To: Conor Dooley, devicetree, Eduard Bostina, Krzysztof Kozlowski, linux-kernel, Mark Brown, Rob Herring Cc: daniel.baluta, simona.toaca, goledhruva, m-chawdhry This series converts the Texas Instruments DSP and IVA Device Tree bindings from text format to DT schema. These conversions are grouped together because the IVA schema explicitly depends on the DSP schema. The DSP is defined as a child node within the IVA subsystem. Eduard Bostina (2): dt-bindings: arm: omap: Convert DSP to DT schema dt-bindings: arm: omap: Convert IVA to DT schema .../devicetree/bindings/arm/omap/dsp.txt | 14 ----- .../devicetree/bindings/arm/omap/iva.txt | 19 ------- .../devicetree/bindings/arm/omap/ti,iva.yaml | 51 +++++++++++++++++++ .../bindings/arm/omap/ti,omap3-c64.yaml | 32 ++++++++++++ 4 files changed, 83 insertions(+), 33 deletions(-) delete mode 100644 Documentation/devicetree/bindings/arm/omap/dsp.txt delete mode 100644 Documentation/devicetree/bindings/arm/omap/iva.txt create mode 100644 Documentation/devicetree/bindings/arm/omap/ti,iva.yaml create mode 100644 Documentation/devicetree/bindings/arm/omap/ti,omap3-c64.yaml -- 2.43.0 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] dt-bindings: arm: omap: Convert DSP to DT schema 2026-06-30 13:28 [PATCH 0/2] dt-bindings: arm: omap: Convert DSP and IVA bindings to DT schema Eduard Bostina @ 2026-06-30 13:28 ` Eduard Bostina 2026-07-02 7:22 ` Krzysztof Kozlowski 2026-06-30 13:28 ` [PATCH 2/2] dt-bindings: arm: omap: Convert IVA " Eduard Bostina 1 sibling, 1 reply; 8+ messages in thread From: Eduard Bostina @ 2026-06-30 13:28 UTC (permalink / raw) To: Conor Dooley, devicetree, Eduard Bostina, Krzysztof Kozlowski, linux-kernel, Mark Brown, Rob Herring Cc: daniel.baluta, simona.toaca, goledhruva, m-chawdhry Convert the Texas Instruments DSP bindings to DT schema. During the conversion, ti,hwmods has been made optional. Signed-off-by: Eduard Bostina <egbostina@gmail.com> --- .../devicetree/bindings/arm/omap/dsp.txt | 14 -------- .../bindings/arm/omap/ti,omap3-c64.yaml | 32 +++++++++++++++++++ 2 files changed, 32 insertions(+), 14 deletions(-) delete mode 100644 Documentation/devicetree/bindings/arm/omap/dsp.txt create mode 100644 Documentation/devicetree/bindings/arm/omap/ti,omap3-c64.yaml diff --git a/Documentation/devicetree/bindings/arm/omap/dsp.txt b/Documentation/devicetree/bindings/arm/omap/dsp.txt deleted file mode 100644 index d3830a32ce08..000000000000 --- a/Documentation/devicetree/bindings/arm/omap/dsp.txt +++ /dev/null @@ -1,14 +0,0 @@ -* TI - DSP (Digital Signal Processor) - -TI DSP included in OMAP SoC - -Required properties: -- compatible : Should be "ti,omap3-c64" for OMAP3 & 4 -- ti,hwmods: "dsp" - -Examples: - -dsp { - compatible = "ti,omap3-c64"; - ti,hwmods = "dsp"; -}; diff --git a/Documentation/devicetree/bindings/arm/omap/ti,omap3-c64.yaml b/Documentation/devicetree/bindings/arm/omap/ti,omap3-c64.yaml new file mode 100644 index 000000000000..72429749ebf4 --- /dev/null +++ b/Documentation/devicetree/bindings/arm/omap/ti,omap3-c64.yaml @@ -0,0 +1,32 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/omap/ti,omap3-c64.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments DSP (Digital Signal Processor) + +maintainers: + - Eduard Bostina <egbostina@gmail.com> + +properties: + compatible: + const: ti,omap3-c64 + + ti,hwmods: + description: Name of the hwmod associated to the dsp + $ref: /schemas/types.yaml#/definitions/string-array + items: + - const: dsp + +required: + - compatible + +additionalProperties: false + +examples: + - | + dsp { + compatible = "ti,omap3-c64"; + ti,hwmods = "dsp"; + }; -- 2.43.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: arm: omap: Convert DSP to DT schema 2026-06-30 13:28 ` [PATCH 1/2] dt-bindings: arm: omap: Convert DSP " Eduard Bostina @ 2026-07-02 7:22 ` Krzysztof Kozlowski 0 siblings, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2026-07-02 7:22 UTC (permalink / raw) To: Eduard Bostina Cc: Conor Dooley, devicetree, Krzysztof Kozlowski, linux-kernel, Mark Brown, Rob Herring, daniel.baluta, simona.toaca, goledhruva, m-chawdhry On Tue, Jun 30, 2026 at 01:28:55PM +0000, Eduard Bostina wrote: > Convert the Texas Instruments DSP bindings to DT schema. > > During the conversion, ti,hwmods has been made optional. You need to explain why. > > Signed-off-by: Eduard Bostina <egbostina@gmail.com> > --- > .../devicetree/bindings/arm/omap/dsp.txt | 14 -------- > .../bindings/arm/omap/ti,omap3-c64.yaml | 32 +++++++++++++++++++ This should be moved to bindings/soc/ti/ directory > 2 files changed, 32 insertions(+), 14 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/omap/dsp.txt > create mode 100644 Documentation/devicetree/bindings/arm/omap/ti,omap3-c64.yaml > > diff --git a/Documentation/devicetree/bindings/arm/omap/dsp.txt b/Documentation/devicetree/bindings/arm/omap/dsp.txt > deleted file mode 100644 > index d3830a32ce08..000000000000 > --- a/Documentation/devicetree/bindings/arm/omap/dsp.txt > +++ /dev/null > @@ -1,14 +0,0 @@ > -* TI - DSP (Digital Signal Processor) > - > -TI DSP included in OMAP SoC > - > -Required properties: > -- compatible : Should be "ti,omap3-c64" for OMAP3 & 4 > -- ti,hwmods: "dsp" > - > -Examples: > - > -dsp { > - compatible = "ti,omap3-c64"; > - ti,hwmods = "dsp"; > -}; > diff --git a/Documentation/devicetree/bindings/arm/omap/ti,omap3-c64.yaml b/Documentation/devicetree/bindings/arm/omap/ti,omap3-c64.yaml > new file mode 100644 > index 000000000000..72429749ebf4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/omap/ti,omap3-c64.yaml > @@ -0,0 +1,32 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/omap/ti,omap3-c64.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments DSP (Digital Signal Processor) > + > +maintainers: > + - Eduard Bostina <egbostina@gmail.com> > + > +properties: > + compatible: > + const: ti,omap3-c64 > + > + ti,hwmods: > + description: Name of the hwmod associated to the dsp > + $ref: /schemas/types.yaml#/definitions/string-array Same comments as before. The type is already fixed to string. Why this has to be an array? Do Linux drivers read it as an array? > + items: > + - const: dsp Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/2] dt-bindings: arm: omap: Convert IVA to DT schema 2026-06-30 13:28 [PATCH 0/2] dt-bindings: arm: omap: Convert DSP and IVA bindings to DT schema Eduard Bostina 2026-06-30 13:28 ` [PATCH 1/2] dt-bindings: arm: omap: Convert DSP " Eduard Bostina @ 2026-06-30 13:28 ` Eduard Bostina 2026-07-02 7:27 ` Krzysztof Kozlowski 1 sibling, 1 reply; 8+ messages in thread From: Eduard Bostina @ 2026-06-30 13:28 UTC (permalink / raw) To: Conor Dooley, devicetree, Eduard Bostina, Krzysztof Kozlowski, linux-kernel, Mark Brown, Rob Herring Cc: daniel.baluta, simona.toaca, goledhruva, m-chawdhry Convert the Texas Instruments IVA bindings to DT schema. During the conversion, several updates were made to reflect actual hardware usage and resolve dtbs_check warnings: - Added a dsp sub node that references the new ti,omap3-c64.yaml schema to support OMAP3 configurations where the DSP is defined as a child of the IVA node. - Updated the compatible property to allow ti,ivahd as a standalone string. - ti,hwmods has been made optional. - Added a second example to demonstrate the OMAP3 configuration with the nested DSP node. Signed-off-by: Eduard Bostina <egbostina@gmail.com> --- .../devicetree/bindings/arm/omap/iva.txt | 19 ------- .../devicetree/bindings/arm/omap/ti,iva.yaml | 51 +++++++++++++++++++ 2 files changed, 51 insertions(+), 19 deletions(-) delete mode 100644 Documentation/devicetree/bindings/arm/omap/iva.txt create mode 100644 Documentation/devicetree/bindings/arm/omap/ti,iva.yaml diff --git a/Documentation/devicetree/bindings/arm/omap/iva.txt b/Documentation/devicetree/bindings/arm/omap/iva.txt deleted file mode 100644 index 6d6295171358..000000000000 --- a/Documentation/devicetree/bindings/arm/omap/iva.txt +++ /dev/null @@ -1,19 +0,0 @@ -* TI - IVA (Imaging and Video Accelerator) subsystem - -The IVA contain various audio, video or imaging HW accelerator -depending of the version. - -Required properties: -- compatible : Should be: - - "ti,ivahd" for OMAP4 - - "ti,iva2.2" for OMAP3 - - "ti,iva2.1" for OMAP2430 - - "ti,iva1" for OMAP2420 -- ti,hwmods: "iva" - -Examples: - -iva { - compatible = "ti,ivahd", "ti,iva"; - ti,hwmods = "iva"; -}; diff --git a/Documentation/devicetree/bindings/arm/omap/ti,iva.yaml b/Documentation/devicetree/bindings/arm/omap/ti,iva.yaml new file mode 100644 index 000000000000..771415196235 --- /dev/null +++ b/Documentation/devicetree/bindings/arm/omap/ti,iva.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/arm/omap/ti,iva.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments IVA (Imaging and Video Accelerator) + +maintainers: + - Eduard Bostina <egbostina@gmail.com> + +properties: + compatible: + oneOf: + - items: + - const: ti,ivahd + - const: ti,iva + - enum: + - ti,iva1 + - ti,iva2.1 + - ti,iva2.2 + - ti,ivahd + + ti,hwmods: + description: Name of the hwmod associated to the iva + $ref: /schemas/types.yaml#/definitions/string + const: iva + + dsp: + type: object + $ref: /schemas/arm/omap/ti,omap3-c64.yaml# + +required: + - compatible + +additionalProperties: false + +examples: + - | + iva { + compatible = "ti,iva2.2"; + ti,hwmods = "iva"; + dsp { + compatible = "ti,omap3-c64"; + }; + }; + - | + iva { + compatible = "ti,ivahd", "ti,iva"; + ti,hwmods = "iva"; + }; -- 2.43.0 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] dt-bindings: arm: omap: Convert IVA to DT schema 2026-06-30 13:28 ` [PATCH 2/2] dt-bindings: arm: omap: Convert IVA " Eduard Bostina @ 2026-07-02 7:27 ` Krzysztof Kozlowski 2026-07-02 14:57 ` Eddie 0 siblings, 1 reply; 8+ messages in thread From: Krzysztof Kozlowski @ 2026-07-02 7:27 UTC (permalink / raw) To: Eduard Bostina Cc: Conor Dooley, devicetree, Krzysztof Kozlowski, linux-kernel, Mark Brown, Rob Herring, daniel.baluta, simona.toaca, goledhruva, m-chawdhry On Tue, Jun 30, 2026 at 01:28:56PM +0000, Eduard Bostina wrote: > Convert the Texas Instruments IVA bindings to DT schema. > > During the conversion, several updates were made to reflect actual hardware > usage and resolve dtbs_check warnings: > - Added a dsp sub node that references the new ti,omap3-c64.yaml > schema to support OMAP3 configurations where the DSP is defined as a > child of the IVA node. > - Updated the compatible property to allow ti,ivahd as a standalone > string. Heh? Old binding already said that, so you did not implement such change. Instead you invented ti,iva without a reason... > - ti,hwmods has been made optional. Why? > - Added a second example to demonstrate the OMAP3 configuration > with the nested DSP node. > > Signed-off-by: Eduard Bostina <egbostina@gmail.com> > --- > .../devicetree/bindings/arm/omap/iva.txt | 19 ------- > .../devicetree/bindings/arm/omap/ti,iva.yaml | 51 +++++++++++++++++++ > 2 files changed, 51 insertions(+), 19 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/omap/iva.txt > create mode 100644 Documentation/devicetree/bindings/arm/omap/ti,iva.yaml > > diff --git a/Documentation/devicetree/bindings/arm/omap/iva.txt b/Documentation/devicetree/bindings/arm/omap/iva.txt > deleted file mode 100644 > index 6d6295171358..000000000000 > --- a/Documentation/devicetree/bindings/arm/omap/iva.txt > +++ /dev/null > @@ -1,19 +0,0 @@ > -* TI - IVA (Imaging and Video Accelerator) subsystem > - > -The IVA contain various audio, video or imaging HW accelerator > -depending of the version. > - > -Required properties: > -- compatible : Should be: > - - "ti,ivahd" for OMAP4 > - - "ti,iva2.2" for OMAP3 > - - "ti,iva2.1" for OMAP2430 > - - "ti,iva1" for OMAP2420 > -- ti,hwmods: "iva" > - > -Examples: > - > -iva { > - compatible = "ti,ivahd", "ti,iva"; > - ti,hwmods = "iva"; > -}; > diff --git a/Documentation/devicetree/bindings/arm/omap/ti,iva.yaml b/Documentation/devicetree/bindings/arm/omap/ti,iva.yaml > new file mode 100644 > index 000000000000..771415196235 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/omap/ti,iva.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/omap/ti,iva.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments IVA (Imaging and Video Accelerator) > + > +maintainers: > + - Eduard Bostina <egbostina@gmail.com> > + > +properties: > + compatible: > + oneOf: > + - items: > + - const: ti,ivahd > + - const: ti,iva From where did you get such list (ti,iva fallback)? ti,iva is completely undocumented and completely unused (not existing), so why it did come up with it? > + - enum: > + - ti,iva1 > + - ti,iva2.1 > + - ti,iva2.2 > + - ti,ivahd This is wrong. ti,ivahd cannot be both: compatible and not compatible with ti,iva > + > + ti,hwmods: > + description: Name of the hwmod associated to the iva > + $ref: /schemas/types.yaml#/definitions/string And here it is a string. Confusing. > + const: iva > + > + dsp: > + type: object > + $ref: /schemas/arm/omap/ti,omap3-c64.yaml# Missing unevaluatedProperties: false. Actually the other binding could be squashed/folded into this place... but split is fine as well. > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + iva { > + compatible = "ti,iva2.2"; > + ti,hwmods = "iva"; > + dsp { > + compatible = "ti,omap3-c64"; > + }; > + }; > + - | > + iva { > + compatible = "ti,ivahd", "ti,iva"; > + ti,hwmods = "iva"; > + }; > -- > 2.43.0 > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] dt-bindings: arm: omap: Convert IVA to DT schema 2026-07-02 7:27 ` Krzysztof Kozlowski @ 2026-07-02 14:57 ` Eddie 2026-07-02 15:03 ` Krzysztof Kozlowski 0 siblings, 1 reply; 8+ messages in thread From: Eddie @ 2026-07-02 14:57 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Conor Dooley, devicetree, Krzysztof Kozlowski, linux-kernel, Mark Brown, Rob Herring, daniel.baluta, simona.toaca, goledhruva, m-chawdhry On Thu, Jul 2, 2026 at 10:27 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Tue, Jun 30, 2026 at 01:28:56PM +0000, Eduard Bostina wrote: > > Convert the Texas Instruments IVA bindings to DT schema. > > > > During the conversion, several updates were made to reflect actual hardware > > usage and resolve dtbs_check warnings: > > - Added a dsp sub node that references the new ti,omap3-c64.yaml > > schema to support OMAP3 configurations where the DSP is defined as a > > child of the IVA node. > > - Updated the compatible property to allow ti,ivahd as a standalone > > string. > > Heh? Old binding already said that, so you did not implement such > change. Instead you invented ti,iva without a reason... I copied ti,iva from the old example and failed to check if it's actually used anymore. I will drop it in v2. > > - ti,hwmods has been made optional. > > Why? I will add the justification to the commit message in v2: the TI hwmod framework is legacy and is being phased out, so new device tree nodes should not be required to include it. > > +properties: > > + compatible: > > + oneOf: > > + - items: > > + - const: ti,ivahd > > + - const: ti,iva > > From where did you get such list (ti,iva fallback)? ti,iva is completely > undocumented and completely unused (not existing), so why it did come up > with it? As mentioned above, this was a mistake carried over from the old .txt example. I will remove it. > > + - enum: > > + - ti,iva1 > > + - ti,iva2.1 > > + - ti,iva2.2 > > + - ti,ivahd > > This is wrong. ti,ivahd cannot be both: compatible and not compatible > with ti,iva Will clean this up by removing the items list and just using a single enum containing the valid strings in v2. > > + > > + ti,hwmods: > > + description: Name of the hwmod associated to the iva > > + $ref: /schemas/types.yaml#/definitions/string > > And here it is a string. Confusing. I will change the DSP ti,hwmods to string too. > > + const: iva > > + > > + dsp: > > + type: object > > + $ref: /schemas/arm/omap/ti,omap3-c64.yaml# > > Missing unevaluatedProperties: false. > > Actually the other binding could be squashed/folded into this place... > but split is fine as well. I will add unevaluatedProperties: false in v2. I will keep them split for now, but I will also move this IVA binding to bindings/soc/ti/ in v2 so that both live in the appropriate directory. Thanks for the review. Best regards, Eduard ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] dt-bindings: arm: omap: Convert IVA to DT schema 2026-07-02 14:57 ` Eddie @ 2026-07-02 15:03 ` Krzysztof Kozlowski 2026-07-02 15:49 ` Eddie 0 siblings, 1 reply; 8+ messages in thread From: Krzysztof Kozlowski @ 2026-07-02 15:03 UTC (permalink / raw) To: Eddie Cc: Conor Dooley, devicetree, Krzysztof Kozlowski, linux-kernel, Mark Brown, Rob Herring, daniel.baluta, simona.toaca, goledhruva, m-chawdhry On 02/07/2026 16:57, Eddie wrote: >>> - ti,hwmods has been made optional. >> >> Why? > > I will add the justification to the commit message in v2: the TI hwmod > framework is legacy and is being phased out, so new device tree nodes > should not be required to include it. This should not be part of the conversion but separate commit with separate reason and analysis of actual ABI usage. During conversion you only make changes necessary to finish it, not things you in general find better. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] dt-bindings: arm: omap: Convert IVA to DT schema 2026-07-02 15:03 ` Krzysztof Kozlowski @ 2026-07-02 15:49 ` Eddie 0 siblings, 0 replies; 8+ messages in thread From: Eddie @ 2026-07-02 15:49 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Conor Dooley, devicetree, Krzysztof Kozlowski, linux-kernel, Mark Brown, Rob Herring, daniel.baluta, simona.toaca, goledhruva, m-chawdhry On Thu, Jul 2, at 18:03, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > I will add the justification to the commit message in v2: the TI hwmod > > framework is legacy and is being phased out, so new device tree nodes > > should not be required to include it. > > This should not be part of the conversion but separate commit with > separate reason and analysis of actual ABI usage. During conversion you > only make changes necessary to finish it, not things you in general find > better. Understood. The reason I included it in the conversion was that keeping hwmods required causes dtbs_check warnings as several dts files omit it. However, I completely understand the need to separate it. For v2, I will structure this as a two patch series per component: 1. A 1:1 conversion keeping ti,hwmods required. 2. A separate patch dropping the requirement, including the ABI analysis in the commit message. Quick question regarding the general rule of thumb for these conversions. I understand the expected pattern is Patch 1 (strict 1:1 conversion) followed by patches fixing the dtbs_check warnings (adding undocumented properties that are used or dropping requirements). For those follow-up fixes, do you prefer one commit per property changed, or is it ok to group all the warning fixes for a specific file into a single follow-up commit? Thanks for the guidance. ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-07-02 15:49 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-06-30 13:28 [PATCH 0/2] dt-bindings: arm: omap: Convert DSP and IVA bindings to DT schema Eduard Bostina 2026-06-30 13:28 ` [PATCH 1/2] dt-bindings: arm: omap: Convert DSP " Eduard Bostina 2026-07-02 7:22 ` Krzysztof Kozlowski 2026-06-30 13:28 ` [PATCH 2/2] dt-bindings: arm: omap: Convert IVA " Eduard Bostina 2026-07-02 7:27 ` Krzysztof Kozlowski 2026-07-02 14:57 ` Eddie 2026-07-02 15:03 ` Krzysztof Kozlowski 2026-07-02 15:49 ` Eddie
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox