Re: [PATCH v5 3/5] arm64: dts: qcom: sm8550-hdk: add SPMI ADC channels and thermal nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit introduces a dependency on a missing header file 'qcom-adc5-gen3.h' and uses undefined parameterized macros, causing a device tree build failure.
--

commit ab1178c40eded5f1628ac18710847436d2e8339b
Author: Neil Armstrong <neil.armstrong@linaro.org>

arm64: dts: qcom: sm8550-hdk: add SPMI ADC channels and thermal nodes

This commit adds the SPMI ADC channels on the PMK8550 SPMI5 ADC3 for the
other PMICS on the system. The thermal nodes are sorted by the sensor
channel to be coherent with the system thermal nodes ordering.

> diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> index ee13e6136a825..96ea55c8c9774 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts

[ ... ]

> @@ -280,6 +280,92 @@ platform {
>  		};
>  	};
>  
> +	thermal-zones {
> +		skin-thermal {
> +			thermal-sensors = <&pmk8550_vadc ADC5_GEN3_AMUX1_THM_100K_PU(1)>;

[Severity: Low]
Is this patch series missing a prerequisite header file? 

Using ADC5_GEN3_AMUX1_THM_100K_PU(1) as a parameterized macro here appears
to cause a DTC syntax error during compilation. It looks like this requires 
qcom-adc5-gen3.h, which seems to be missing from both the patch series and 
the current kernel tree. If the tree only contains object-like definitions 
for these macros, the preprocessor will not expand them correctly.

[ ... ]

> +&pmk8550_vadc {
> +	/* PM8550 Channel nodes */
> +	channel@100 {
> +		reg = <ADC5_GEN3_REF_GND(1)>;
> +		label = "pm8550_offset_ref";
> +		qcom,pre-scaling = <1 1>;
> +	};
> +
> +	channel@101 {
> +		reg = <ADC5_GEN3_1P25VREF(1)>;
> +		label = "pm8550_vref_1p25";
> +		qcom,pre-scaling = <1 1>;
> +	};
> +
> +	channel@103 {
> +		reg = <ADC5_GEN3_DIE_TEMP(1)>;

[Severity: Low]
Does this location also suffer from the same missing macro definition issue?
Without a function-like macro defined for ADC5_GEN3_DIE_TEMP, this will
likely fail to expand correctly and result in a build break when running
make dtbs.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702-topic-sm8x50-adc5-gen3-v5-0-8169953634ad@linaro.org?part=3