From: sashiko-bot@kernel.org
To: "Sarat Addepalli" <sarat.addepalli@oss.qualcomm.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v3] arm64: dts: qcom: qcom6490-idp: Add IPA nodes
Date: Thu, 02 Jul 2026 11:06:32 +0000 [thread overview]
Message-ID: <20260702110633.3BFF51F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260702105509.1360340-1-sarat.addepalli@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing `qcom,gsi-loader` and `memory-region` properties in the `&ipa` node cause driver probe to fail.
--
commit 340452b6b574043f9bbb5c7064a4d13788d8709e
Author: Sarat Addepalli <sarat.addepalli@oss.qualcomm.com>
arm64: dts: qcom: qcom6490-idp: Add IPA nodes
This commit adds the IPA nodes for the Qualcomm qcm6490 board by enabling
the &ipa node and setting the firmware name in qcm6490-idp.dts.
Link: https://lore.kernel.org/all/20260517-ipa-loader-v1-0-3c3764c1b4a3@oss.qualcomm.com/
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index bdc02260f902b..d4f96bdd3a90b 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -619,6 +619,11 @@ &gpu_zap_shader {
> firmware-name = "qcom/qcm6490/a660_zap.mbn";
> };
>
> +&ipa {
> + firmware-name = "qcom/qcm6490/ipa_fws.mbn";
> + status = "okay";
> +};
[Severity: High]
Does kodiak.dtsi actually provide the qcom,gsi-loader and memory-region
properties at this revision?
If they are missing from kodiak.dtsi, the IPA driver defaults to
IPA_LOADER_SELF (since modem-init is also absent) and requires a memory-region.
Without it, ipa_probe() in drivers/net/ipa/ipa_main.c will fail with -EINVAL
when it calls ipa_firmware_load() -> of_reserved_mem_region_to_resource().
Will this cause the IPA driver probe to fail on this board?
> +
> &lpass_rx_macro {
> status = "okay";
> };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260702105509.1360340-1-sarat.addepalli@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-07-02 11:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-18 12:47 [PATCH v2] arm64: dts: qcom: qcom6490-idp: Add IPA nodes Sarat Addepalli
2026-06-18 12:56 ` Konrad Dybcio
2026-06-18 12:59 ` Dmitry Baryshkov
2026-07-02 10:55 ` [PATCH v3] " Sarat Addepalli
2026-07-02 11:06 ` sashiko-bot [this message]
2026-07-02 11:51 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260702110633.3BFF51F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sarat.addepalli@oss.qualcomm.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox