[PATCH v2] arm64: dts: qcom: qcom6490-idp: Add IPA nodes

[PATCH v2] arm64: dts: qcom: qcom6490-idp: Add IPA nodes

[Sarat Addepalli]

Add IPA nodes for Qualcomm qcm6490 board.

Signed-off-by: Sarat Addepalli <sarat.addepalli@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
index bdc02260f902..fd1aa26e20f1 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
@@ -619,6 +619,13 @@ &gpu_zap_shader {
 	firmware-name = "qcom/qcm6490/a660_zap.mbn";
 };
 
+&ipa {
+	qcom,gsi-loader = "self";
+	memory-region = <&ipa_fw_mem>;
+	firmware-name = "qcom/qcm6490/ipa_fws.mbn";
+	status = "okay";
+};
+
 &lpass_rx_macro {
 	status = "okay";
 };

Re: [PATCH v2] arm64: dts: qcom: qcom6490-idp: Add IPA nodes

[Konrad Dybcio]

On 6/18/26 2:47 PM, Sarat Addepalli wrote:
> Add IPA nodes for Qualcomm qcm6490 board.
> 
> Signed-off-by: Sarat Addepalli <sarat.addepalli@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index bdc02260f902..fd1aa26e20f1 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -619,6 +619,13 @@ &gpu_zap_shader {
>  	firmware-name = "qcom/qcm6490/a660_zap.mbn";
>  };
>  
> +&ipa {
> +	qcom,gsi-loader = "self";
> +	memory-region = <&ipa_fw_mem>;
> +	firmware-name = "qcom/qcm6490/ipa_fws.mbn";
> +	status = "okay";

Please rebase atop 

https://lore.kernel.org/linux-arm-msm/20260517-ipa-loader-v1-0-3c3764c1b4a3@oss.qualcomm.com/

Konrad

Re: [PATCH v2] arm64: dts: qcom: qcom6490-idp: Add IPA nodes

[Dmitry Baryshkov]

On Thu, Jun 18, 2026 at 06:17:00PM +0530, Sarat Addepalli wrote:
> Add IPA nodes for Qualcomm qcm6490 board.
> 
> Signed-off-by: Sarat Addepalli <sarat.addepalli@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 7 +++++++
>  1 file changed, 7 insertions(+)

Please rebase on top of https://lore.kernel.org/all/20260517-ipa-loader-v1-0-3c3764c1b4a3@oss.qualcomm.com/

> 
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index bdc02260f902..fd1aa26e20f1 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -619,6 +619,13 @@ &gpu_zap_shader {
>  	firmware-name = "qcom/qcm6490/a660_zap.mbn";
>  };
>  
> +&ipa {
> +	qcom,gsi-loader = "self";
> +	memory-region = <&ipa_fw_mem>;
> +	firmware-name = "qcom/qcm6490/ipa_fws.mbn";
> +	status = "okay";
> +};
> +
>  &lpass_rx_macro {
>  	status = "okay";
>  };

-- 
With best wishes
Dmitry

[PATCH v3] arm64: dts: qcom: qcom6490-idp: Add IPA nodes

[Sarat Addepalli]

Add IPA nodes for Qualcomm qcm6490 board.

The qcom,gsi-loader and memory-region properties are provided by
kodiak.dtsi as part of the IPA property consolidation work, so only
the board-specific firmware-name and status properties need to be set.

Link: https://lore.kernel.org/all/20260517-ipa-loader-v1-0-3c3764c1b4a3@oss.qualcomm.com/

Signed-off-by: Sarat Addepalli <sarat.addepalli@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
index bdc02260f902..d4f96bdd3a90 100644
--- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
+++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
@@ -619,6 +619,11 @@ &gpu_zap_shader {
 	firmware-name = "qcom/qcm6490/a660_zap.mbn";
 };
 
+&ipa {
+	firmware-name = "qcom/qcm6490/ipa_fws.mbn";
+	status = "okay";
+};
+
 &lpass_rx_macro {
 	status = "okay";
 };

Re: [PATCH v3] arm64: dts: qcom: qcom6490-idp: Add IPA nodes

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing `qcom,gsi-loader` and `memory-region` properties in the `&ipa` node cause driver probe to fail.
--

commit 340452b6b574043f9bbb5c7064a4d13788d8709e
Author: Sarat Addepalli <sarat.addepalli@oss.qualcomm.com>

arm64: dts: qcom: qcom6490-idp: Add IPA nodes

This commit adds the IPA nodes for the Qualcomm qcm6490 board by enabling
the &ipa node and setting the firmware name in qcm6490-idp.dts.

Link: https://lore.kernel.org/all/20260517-ipa-loader-v1-0-3c3764c1b4a3@oss.qualcomm.com/

> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index bdc02260f902b..d4f96bdd3a90b 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -619,6 +619,11 @@ &gpu_zap_shader {
>  	firmware-name = "qcom/qcm6490/a660_zap.mbn";
>  };
>  
> +&ipa {
> +	firmware-name = "qcom/qcm6490/ipa_fws.mbn";
> +	status = "okay";
> +};

[Severity: High]
Does kodiak.dtsi actually provide the qcom,gsi-loader and memory-region
properties at this revision?

If they are missing from kodiak.dtsi, the IPA driver defaults to
IPA_LOADER_SELF (since modem-init is also absent) and requires a memory-region.
Without it, ipa_probe() in drivers/net/ipa/ipa_main.c will fail with -EINVAL
when it calls ipa_firmware_load() -> of_reserved_mem_region_to_resource().

Will this cause the IPA driver probe to fail on this board?

> +
>  &lpass_rx_macro {
>  	status = "okay";
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702105509.1360340-1-sarat.addepalli@oss.qualcomm.com?part=1

Re: [PATCH v3] arm64: dts: qcom: qcom6490-idp: Add IPA nodes

[Dmitry Baryshkov]

On Thu, Jul 02, 2026 at 04:25:09PM +0530, Sarat Addepalli wrote:
> Add IPA nodes for Qualcomm qcm6490 board.
> 
> The qcom,gsi-loader and memory-region properties are provided by
> kodiak.dtsi as part of the IPA property consolidation work, so only
> the board-specific firmware-name and status properties need to be set.
> 
> Link: https://lore.kernel.org/all/20260517-ipa-loader-v1-0-3c3764c1b4a3@oss.qualcomm.com/
> 
> Signed-off-by: Sarat Addepalli <sarat.addepalli@oss.qualcomm.com>

No empty lines between tags. Also please don't post new revisions of the
patches as replies to earlier series. Always start a new thread. It's
documented under Documentation/process/

> ---
>  arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 5 +++++
>  1 file changed, 5 insertions(+)

Missing changelog between patch iterations. Please fix it for the next
revision.

> 
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index bdc02260f902..d4f96bdd3a90 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -619,6 +619,11 @@ &gpu_zap_shader {
>  	firmware-name = "qcom/qcm6490/a660_zap.mbn";
>  };
>  
> +&ipa {
> +	firmware-name = "qcom/qcm6490/ipa_fws.mbn";
> +	status = "okay";

Empty line before the status property, please.

> +};
> +
>  &lpass_rx_macro {
>  	status = "okay";
>  };

-- 
With best wishes
Dmitry