Re: [PATCH v3 2/4] dt-bindings: power: limits: Describe Qualcomm SPEL hardware

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The YAML `description` string will lose its structural formatting (specifically the bulleted list) because it is defined as a plain scalar.
--

commit 2a8dfbf8a7cefb27618383801964875a7eaac9ea
Author: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>

dt-bindings: power: limits: Describe Qualcomm SPEL hardware

This commit adds a DeviceTree binding to describe the Qualcomm SPEL
(SoC Power and Electrical Limits) hardware block. SPEL provides power
monitoring and limiting capabilities for various power domains in
Qualcomm SoCs.

> diff --git a/Documentation/devicetree/bindings/power/limits/qcom,glymur-spel.yaml b/Documentation/devicetree/bindings/power/limits/qcom,glymur-spel.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/limits/qcom,glymur-spel.yaml

[ ... ]

> +maintainers:
> +  - Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
> +
> +description:

[Severity: Low]
This isn't a bug, but should this use the literal block scalar indicator
(description: |) to preserve the line breaks?

Because this is currently defined as a plain scalar, the YAML parser will fold
single newlines into spaces. This will cause the bulleted list below to
collapse into a single unformatted run-on sentence when the documentation
is generated by tools like dt_binding_check.

> +  The Qualcomm SPEL (SoC Power and Electrical Limits) is a hardware block that
> +  provides power monitoring and limiting capabilities for various power domains
> +  in Qualcomm SoCs.
> +
> +  SPEL enforces power consumption limits to prevent thermal overload, maintain
> +  system stability, and comply with platform power budgets. It provides
> +    - Hardware-enforced power capping with configurable power limits
> +    - Time window controls for power averaging
> +    - Energy counter monitoring for each power domain
> +    - Automatic throttling when power limits are exceeded

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260702-qcom_spel_driver_upstream-v3-0-434d50f0c5b0@oss.qualcomm.com?part=2