Re: [PATCH v4 02/10] dt-bindings: remoteproc: qcom,pas: add #cooling-cells property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added example fails `dt_binding_check` due to missing required properties.
--

commit d6d7b5d5f32286193dde6ee3686dfbc725c49024
Author: Gaurav Kohli <gaurav.kohli@oss.qualcomm.com>

dt-bindings: remoteproc: qcom,pas: add #cooling-cells property

This commit documents the optional #cooling-cells property for Qualcomm PAS
remoteproc nodes. It allows them to be used as thermal cooling devices via
the QMI Thermal Mitigation Device interface, and adds an example configuration.

> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
> index 4607b459131b4..ef11371058c4f 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
[ ... ]
> @@ -95,3 +103,34 @@ required:
>    - qcom,smem-state-names
>  
>  additionalProperties: true
> +
> +examples:
> +  - |
> +    #include <dt-bindings/thermal/thermal.h>
> +    #include <dt-bindings/firmware/qcom,qmi-tmd.h>
> +
> +    remoteproc: remoteproc {
> +      #cooling-cells = <3>;
> +    };

[Severity: Low]
Will this new example fail dt_binding_check?

Looking at the required list for this schema document, properties like clocks,
clock-names, interrupts, interrupt-names, qcom,smem-states, and
qcom,smem-state-names are mandatory. Because they are omitted from this
remoteproc example node, schema validation will likely fail when the build
system validates the examples.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260703-qmi-tmd-v4-0-3882189c1f83@oss.qualcomm.com?part=2