* [PATCH RESEND] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE
@ 2026-07-04 0:44 Shawn Guo
2026-07-05 17:45 ` Kuldeep Singh
0 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2026-07-04 0:44 UTC (permalink / raw)
To: Herbert Xu
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Dmitry Baryshkov, Bartosz Golaszewski,
Deepti Jaggi, linux-crypto, devicetree, linux-arm-msm,
linux-kernel, Shawn Guo, Krzysztof Kozlowski, Harshal Dev
Document Inline Crypto Engine (ICE) on Qualcomm Nord SoC.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Reviewed-by: Harshal Dev <harshal.dev@oss.qualcomm.com>
Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
---
It was included in the Nord SA8797P DTS series [1] due to that
the prerequisite changes were picked up by Bjorn for 7.2. Resend it to
Herbert as the dependency is gone now with 7.2-rc1.
[1] https://lore.kernel.org/all/20260526051300.1669201-1-shengchao.guo@oss.qualcomm.com/
.../devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
index db895c50e2d2..d690eff2e86d 100644
--- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
@@ -17,6 +17,7 @@ properties:
- qcom,hawi-inline-crypto-engine
- qcom,kaanapali-inline-crypto-engine
- qcom,milos-inline-crypto-engine
+ - qcom,nord-inline-crypto-engine
- qcom,qcs8300-inline-crypto-engine
- qcom,sa8775p-inline-crypto-engine
- qcom,sc7180-inline-crypto-engine
@@ -63,6 +64,7 @@ allOf:
enum:
- qcom,eliza-inline-crypto-engine
- qcom,milos-inline-crypto-engine
+ - qcom,nord-inline-crypto-engine
then:
required:
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE
2026-07-04 0:44 [PATCH RESEND] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE Shawn Guo
@ 2026-07-05 17:45 ` Kuldeep Singh
2026-07-06 6:54 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Kuldeep Singh @ 2026-07-05 17:45 UTC (permalink / raw)
To: Shawn Guo, Herbert Xu
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Dmitry Baryshkov, Bartosz Golaszewski,
Deepti Jaggi, linux-crypto, devicetree, linux-arm-msm,
linux-kernel, Krzysztof Kozlowski, Harshal Dev
On 04-07-2026 06:14, Shawn Guo wrote:
> Document Inline Crypto Engine (ICE) on Qualcomm Nord SoC.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Reviewed-by: Harshal Dev <harshal.dev@oss.qualcomm.com>
> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
> ---
> It was included in the Nord SA8797P DTS series [1] due to that
> the prerequisite changes were picked up by Bjorn for 7.2. Resend it to
> Herbert as the dependency is gone now with 7.2-rc1.
>
> [1] https://lore.kernel.org/all/20260526051300.1669201-1-shengchao.guo@oss.qualcomm.com/
>
> .../devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> index db895c50e2d2..d690eff2e86d 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> @@ -17,6 +17,7 @@ properties:
> - qcom,hawi-inline-crypto-engine
> - qcom,kaanapali-inline-crypto-engine
> - qcom,milos-inline-crypto-engine
> + - qcom,nord-inline-crypto-engine
> - qcom,qcs8300-inline-crypto-engine
> - qcom,sa8775p-inline-crypto-engine
> - qcom,sc7180-inline-crypto-engine
> @@ -63,6 +64,7 @@ allOf:
> enum:
> - qcom,eliza-inline-crypto-engine
> - qcom,milos-inline-crypto-engine
> + - qcom,nord-inline-crypto-engine
With below patch, we don't need nord entry here.
https://lore.kernel.org/lkml/20260702-b4-shikra_crypto_changse-v2-1-66173f2f28b3@qti.qualcomm.com/
--
Regards
Kuldeep
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE
2026-07-05 17:45 ` Kuldeep Singh
@ 2026-07-06 6:54 ` Krzysztof Kozlowski
2026-07-06 17:13 ` Bartosz Golaszewski
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-06 6:54 UTC (permalink / raw)
To: Kuldeep Singh
Cc: Shawn Guo, Herbert Xu, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio, Dmitry Baryshkov,
Bartosz Golaszewski, Deepti Jaggi, linux-crypto, devicetree,
linux-arm-msm, linux-kernel, Krzysztof Kozlowski, Harshal Dev
On Sun, Jul 05, 2026 at 11:15:45PM +0530, Kuldeep Singh wrote:
> On 04-07-2026 06:14, Shawn Guo wrote:
> > Document Inline Crypto Engine (ICE) on Qualcomm Nord SoC.
> >
> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > Reviewed-by: Harshal Dev <harshal.dev@oss.qualcomm.com>
> > Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
> > ---
> > It was included in the Nord SA8797P DTS series [1] due to that
> > the prerequisite changes were picked up by Bjorn for 7.2. Resend it to
> > Herbert as the dependency is gone now with 7.2-rc1.
> >
> > [1] https://lore.kernel.org/all/20260526051300.1669201-1-shengchao.guo@oss.qualcomm.com/
> >
> > .../devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> > index db895c50e2d2..d690eff2e86d 100644
> > --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> > +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
> > @@ -17,6 +17,7 @@ properties:
> > - qcom,hawi-inline-crypto-engine
> > - qcom,kaanapali-inline-crypto-engine
> > - qcom,milos-inline-crypto-engine
> > + - qcom,nord-inline-crypto-engine
> > - qcom,qcs8300-inline-crypto-engine
> > - qcom,sa8775p-inline-crypto-engine
> > - qcom,sc7180-inline-crypto-engine
> > @@ -63,6 +64,7 @@ allOf:
> > enum:
> > - qcom,eliza-inline-crypto-engine
> > - qcom,milos-inline-crypto-engine
> > + - qcom,nord-inline-crypto-engine
>
> With below patch, we don't need nord entry here.
> https://lore.kernel.org/lkml/20260702-b4-shikra_crypto_changse-v2-1-66173f2f28b3@qti.qualcomm.com/
Patch has conflict. This (Nord) should go after above one, with this
fixed.
>
> --
> Regards
> Kuldeep
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE
2026-07-06 6:54 ` Krzysztof Kozlowski
@ 2026-07-06 17:13 ` Bartosz Golaszewski
2026-07-06 17:33 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Bartosz Golaszewski @ 2026-07-06 17:13 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Shawn Guo, Herbert Xu, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio, Dmitry Baryshkov,
Bartosz Golaszewski, Deepti Jaggi, linux-crypto, devicetree,
linux-arm-msm, linux-kernel, Krzysztof Kozlowski, Harshal Dev,
Kuldeep Singh
On Mon, 6 Jul 2026 08:54:22 +0200, Krzysztof Kozlowski <krzk@kernel.org> said:
> On Sun, Jul 05, 2026 at 11:15:45PM +0530, Kuldeep Singh wrote:
>> On 04-07-2026 06:14, Shawn Guo wrote:
>> > Document Inline Crypto Engine (ICE) on Qualcomm Nord SoC.
>> >
>> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>> > Reviewed-by: Harshal Dev <harshal.dev@oss.qualcomm.com>
>> > Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
>> > ---
>> > It was included in the Nord SA8797P DTS series [1] due to that
>> > the prerequisite changes were picked up by Bjorn for 7.2. Resend it to
>> > Herbert as the dependency is gone now with 7.2-rc1.
>> >
>> > [1] https://lore.kernel.org/all/20260526051300.1669201-1-shengchao.guo@oss.qualcomm.com/
>> >
>> > .../devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 2 ++
>> > 1 file changed, 2 insertions(+)
>> >
>> > diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
>> > index db895c50e2d2..d690eff2e86d 100644
>> > --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
>> > +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
>> > @@ -17,6 +17,7 @@ properties:
>> > - qcom,hawi-inline-crypto-engine
>> > - qcom,kaanapali-inline-crypto-engine
>> > - qcom,milos-inline-crypto-engine
>> > + - qcom,nord-inline-crypto-engine
>> > - qcom,qcs8300-inline-crypto-engine
>> > - qcom,sa8775p-inline-crypto-engine
>> > - qcom,sc7180-inline-crypto-engine
>> > @@ -63,6 +64,7 @@ allOf:
>> > enum:
>> > - qcom,eliza-inline-crypto-engine
>> > - qcom,milos-inline-crypto-engine
>> > + - qcom,nord-inline-crypto-engine
>>
>> With below patch, we don't need nord entry here.
>> https://lore.kernel.org/lkml/20260702-b4-shikra_crypto_changse-v2-1-66173f2f28b3@qti.qualcomm.com/
>
> Patch has conflict. This (Nord) should go after above one, with this
> fixed.
>
The other series still hasn't made its way upstream. This one's simple, can we
queue it now and rebase the other one?
Bart
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE
2026-07-06 17:13 ` Bartosz Golaszewski
@ 2026-07-06 17:33 ` Krzysztof Kozlowski
2026-07-06 18:25 ` Kuldeep Singh
0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-06 17:33 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Shawn Guo, Herbert Xu, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio, Dmitry Baryshkov,
Bartosz Golaszewski, Deepti Jaggi, linux-crypto, devicetree,
linux-arm-msm, linux-kernel, Krzysztof Kozlowski, Harshal Dev,
Kuldeep Singh
On 06/07/2026 19:13, Bartosz Golaszewski wrote:
> On Mon, 6 Jul 2026 08:54:22 +0200, Krzysztof Kozlowski <krzk@kernel.org> said:
>> On Sun, Jul 05, 2026 at 11:15:45PM +0530, Kuldeep Singh wrote:
>>> On 04-07-2026 06:14, Shawn Guo wrote:
>>>> Document Inline Crypto Engine (ICE) on Qualcomm Nord SoC.
>>>>
>>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>>>> Reviewed-by: Harshal Dev <harshal.dev@oss.qualcomm.com>
>>>> Signed-off-by: Shawn Guo <shengchao.guo@oss.qualcomm.com>
>>>> ---
>>>> It was included in the Nord SA8797P DTS series [1] due to that
>>>> the prerequisite changes were picked up by Bjorn for 7.2. Resend it to
>>>> Herbert as the dependency is gone now with 7.2-rc1.
>>>>
>>>> [1] https://lore.kernel.org/all/20260526051300.1669201-1-shengchao.guo@oss.qualcomm.com/
>>>>
>>>> .../devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
>>>> index db895c50e2d2..d690eff2e86d 100644
>>>> --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
>>>> +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml
>>>> @@ -17,6 +17,7 @@ properties:
>>>> - qcom,hawi-inline-crypto-engine
>>>> - qcom,kaanapali-inline-crypto-engine
>>>> - qcom,milos-inline-crypto-engine
>>>> + - qcom,nord-inline-crypto-engine
>>>> - qcom,qcs8300-inline-crypto-engine
>>>> - qcom,sa8775p-inline-crypto-engine
>>>> - qcom,sc7180-inline-crypto-engine
>>>> @@ -63,6 +64,7 @@ allOf:
>>>> enum:
>>>> - qcom,eliza-inline-crypto-engine
>>>> - qcom,milos-inline-crypto-engine
>>>> + - qcom,nord-inline-crypto-engine
>>>
>>> With below patch, we don't need nord entry here.
>>> https://lore.kernel.org/lkml/20260702-b4-shikra_crypto_changse-v2-1-66173f2f28b3@qti.qualcomm.com/
>>
>> Patch has conflict. This (Nord) should go after above one, with this
>> fixed.
>>
>
> The other series still hasn't made its way upstream. This one's simple, can we
> queue it now and rebase the other one?
This is not point of rebase, but conflicting work.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH RESEND] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE
2026-07-06 17:33 ` Krzysztof Kozlowski
@ 2026-07-06 18:25 ` Kuldeep Singh
0 siblings, 0 replies; 6+ messages in thread
From: Kuldeep Singh @ 2026-07-06 18:25 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bartosz Golaszewski
Cc: Shawn Guo, Herbert Xu, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio, Dmitry Baryshkov,
Bartosz Golaszewski, Deepti Jaggi, linux-crypto, devicetree,
linux-arm-msm, linux-kernel, Krzysztof Kozlowski, Harshal Dev,
Jingyi Wang
>>>> With below patch, we don't need nord entry here.
>>>> https://lore.kernel.org/lkml/20260702-b4-shikra_crypto_changse-v2-1-66173f2f28b3@qti.qualcomm.com/
>>>
>>> Patch has conflict. This (Nord) should go after above one, with this
>>> fixed.
>>>
>>
>> The other series still hasn't made its way upstream. This one's simple, can we
>> queue it now and rebase the other one?
>
> This is not point of rebase, but conflicting work.
Yes, my patch[1] can be accepted straightaway(after review) as it has no
dependency on any other changes. The rest series has dependency but not
patch 1/6.
It's best if 1/6 goes in followed by the other efforts(Shawn for nord
and Jingyi for maili/hawi) to avoid conflicts.
[1]
https://lore.kernel.org/lkml/20260706-b4-shikra_crypto_changse-v3-1-23b4c2054227@oss.qualcomm.com/
--
Regards
Kuldeep
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-07-06 18:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-04 0:44 [PATCH RESEND] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE Shawn Guo
2026-07-05 17:45 ` Kuldeep Singh
2026-07-06 6:54 ` Krzysztof Kozlowski
2026-07-06 17:13 ` Bartosz Golaszewski
2026-07-06 17:33 ` Krzysztof Kozlowski
2026-07-06 18:25 ` Kuldeep Singh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox