Re: [PATCH v4 2/2] arm64: dts: qcom: x1e78100-t14s: Add thermal zones for keyboard skin and charging sensors

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch adds the `#thermal-sensor-cells = <1>;` property to the `embedded-controller@28` node without a corresponding update to the device tree binding document (`lenovo,thinkpad-t14s-ec.yaml`), violating the DT schema.
--

commit 6785b707e0b11ce8dd5032f0c96a9debef8c413f
Author: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>

arm64: dts: qcom: x1e78100-t14s: Add thermal zones for keyboard skin and charging sensors

This commit exposes the Lenovo ThinkPad T14s embedded controller as a thermal
sensor provider and adds thermal zones for the keyboard skin and charging
sensors in the device tree. It allows the thermal framework to apply CPU
throttling when the charging circuitry exceeds passive thresholds.

> diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
> index 5d49df41be02a..ed5ba3a428a8d 100644
> --- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
> @@ -979,7 +979,7 @@ &i2c6 {
>  
>  	status = "okay";
>  
> -	embedded-controller@28 {
> +	ec: embedded-controller@28 {
>  		compatible = "lenovo,thinkpad-t14s-ec";
>  		reg = <0x28>;
>  
> @@ -988,6 +988,8 @@ embedded-controller@28 {
>  		pinctrl-0 = <&ec_int_n_default>;
>  		pinctrl-names = "default";
>  
> +		#thermal-sensor-cells = <1>;

[Severity: Low]
Does adding this property to the embedded-controller@28 node without a
corresponding update to the binding schema cause make dtbs_check to emit
validation warnings?

Since the lenovo,thinkpad-t14s-ec.yaml binding does not define this property
and uses additionalProperties: false, it seems that adding it here will
trigger a warning. Should the schema be updated to allow this property?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260706160830.17698-1-daniel.lezcano@oss.qualcomm.com?part=2