Re: [PATCH 11/12] dt-bindings: arm: rockchip: Add Luckfox Pico Mini B

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new compatible block for 'Luckfox Pico Mini B' is inserted out of alphabetical order in the binding list.
--

commit fc06cf28ad2eaf0cae38df99becb9a16d3aee26b
Author: Simon Glass <sjg@chromium.org>

dt-bindings: arm: rockchip: Add Luckfox Pico Mini B

This commit adds the device tree binding compatible strings for the Luckfox
Pico Mini B board. The board utilizes a Rockchip RV1103 SoC.

> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 1a9dde18626d0..711029ee78af2 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml

[ ... ]

> @@ -813,6 +813,11 @@ properties:
>            - const: netxeon,r89
>            - const: rockchip,rk3288
>  
> +      - description: Luckfox Pico Mini B
> +        items:
> +          - const: luckfox,pico-mini-b

[Severity: Low]
This isn't a bug, but should this entry be placed higher up in the file to 
maintain alphabetical ordering? It looks like "luckfox" is being inserted 
between "netxeon" and "onion", which breaks the alphabetical sorting of the
list.

> +          - const: rockchip,rv1103
> +
>        - description: Onion Omega4 Evaluation board
>          items:
>            - const: onion,omega4-evb

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260706195818.3906949-1-sjg@chromium.org?part=11