Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Yanan He" <grumpycat921013@gmail.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/5] dt-bindings: arm: rockchip: Add Alientek DLRV1126
Date: Tue, 07 Jul 2026 09:15:55 +0000	[thread overview]
Message-ID: <20260707091556.57A0D1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260706-rv1126-alientek-dlrv1126-v2-2-ff3176ca362b@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new board entry is not sorted alphabetically within `rockchip.yaml`.
--

commit e33fe7223e96705f47efcf1b94f1097936d189f9
Author: Yanan He <grumpycat921013@gmail.com>

dt-bindings: arm: rockchip: Add Alientek DLRV1126

This commit adds device tree binding documentation for the Alientek DLRV1126 
carrier board and CLRV1126F core module, based on the Rockchip RV1126 SoC.

> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 1a9dde18626d0..9058f2a461d57 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -162,6 +162,13 @@ properties:
>            - const: coolpi,pi-4b
>            - const: rockchip,rk3588s
>  
> +      - description: Alientek CLRV1126F SoM based boards

[Severity: Low]
This isn't a bug, but should this entry be sorted alphabetically? The list
appears to be maintained in alphabetical order by description, and "Alientek"
is being inserted here between "Cool Pi" and "Edgeble".

> +        items:
> +          - enum:
> +              - alientek,dlrv1126
> +          - const: alientek,clrv1126f
> +          - const: rockchip,rv1126
> +
>        - description: Edgeble Neural Compute Module 2(Neu2) SoM based boards
>          items:
>            - const: edgeble,neural-compute-module-2-io   # Edgeble Neural Compute Module 2 IO Board

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260706-rv1126-alientek-dlrv1126-v2-0-ff3176ca362b@gmail.com?part=2

  parent reply	other threads:[~2026-07-07  9:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06  9:14 [PATCH v2 0/5] ARM: rockchip: rv1126: Add support for Alientek ATK-DLRV1126 Yanan He
2026-07-06  9:14 ` [PATCH v2 1/5] dt-bindings: vendor-prefixes: add alientek Yanan He
2026-07-06  9:14 ` [PATCH v2 2/5] dt-bindings: arm: rockchip: Add Alientek DLRV1126 Yanan He
2026-07-06 16:59   ` Conor Dooley
2026-07-07  9:15   ` sashiko-bot [this message]
2026-07-06  9:14 ` [PATCH v2 3/5] net: phy: motorcomm: Enable optional clock for YT8531 Yanan He
2026-07-06 14:56   ` Andrew Lunn
2026-07-06 14:57   ` Andrew Lunn
2026-07-06  9:14 ` [PATCH v2 4/5] ARM: dts: rockchip: Add RV1126 I2C5 Yanan He
2026-07-07  9:15   ` sashiko-bot
2026-07-06  9:14 ` [PATCH v2 5/5] ARM: dts: rockchip: Add Alientek DLRV1126 Yanan He
2026-07-06 15:25   ` Andrew Lunn
2026-07-07  9:15   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260707091556.57A0D1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=grumpycat921013@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox