Re: [PATCH v2 5/5] ARM: dts: rockchip: Add Alientek DLRV1126

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] WiFi SDIO node requests `keep-power-in-suspend`, but its vmmc regulator is hard-coded to cut power in suspend.
--

commit 4b7539a0242320f89cb11cc0a91f5ab56293439d
Author: Yanan He <grumpycat921013@gmail.com>

ARM: dts: rockchip: Add Alientek DLRV1126

This commit adds device tree support for the Alientek DLRV1126 board
and its CLRV1126F core module, enabling Ethernet, SD card, WiFi/BT,
and other peripherals.

> diff --git a/arch/arm/boot/dts/rockchip/rv1126-alientek-clrv1126f.dtsi b/arch/arm/boot/dts/rockchip/rv1126-alientek-clrv1126f.dtsi
> index 0000000000000..9bee424b17979
> --- /dev/null
> +++ b/arch/arm/boot/dts/rockchip/rv1126-alientek-clrv1126f.dtsi

[ ... ]

> +			vcc3v3_sd: LDO_REG9 {
> +				regulator-name = "vcc3v3_sd";
> +				regulator-always-on;
> +				regulator-boot-on;
> +				regulator-min-microvolt = <3300000>;
> +				regulator-max-microvolt = <3300000>;
> +				regulator-state-mem {
> +					regulator-off-in-suspend;
> +				};
> +			};

[ ... ]

> diff --git a/arch/arm/boot/dts/rockchip/rv1126-alientek-dlrv1126.dts b/arch/arm/boot/dts/rockchip/rv1126-alientek-dlrv1126.dts
> index 0000000000000..33c6c74d08b91
> --- /dev/null
> +++ b/arch/arm/boot/dts/rockchip/rv1126-alientek-dlrv1126.dts

[ ... ]

> +&sdio {
> +	bus-width = <4>;
> +	cap-sdio-irq;
> +	keep-power-in-suspend;
> +	max-frequency = <25000000>;
> +	mmc-pwrseq = <&sdio_pwrseq>;
> +	non-removable;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&sdmmc1_clk &sdmmc1_cmd &sdmmc1_bus4>;
> +	rockchip,default-sample-phase = <90>;
> +	vmmc-supply = <&vcc3v3_sd>;

[Severity: High]
Will the WiFi module fail to function after a system suspend and resume?

The sdio node requests keep-power-in-suspend, so the MMC subsystem will
skip tearing down the SDIO card during suspend. However, the vmmc-supply
regulator (vcc3v3_sd) is explicitly configured to cut power in suspend via
regulator-off-in-suspend.

Upon resume, the MMC subsystem might assume the WiFi chip retained its
state, but it would have actually lost power and reset. Could this state
mismatch wipe the firmware state and lead to SDIO timeouts?

> +	vqmmc-supply = <&vcc_1v8>;
> +	status = "okay";
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260706-rv1126-alientek-dlrv1126-v2-0-ff3176ca362b@gmail.com?part=5