[PATCH v8 0/2] iio: health: add MAX86150 ECG and PPG biosensor driver

[PATCH v8 0/2] iio: health: add MAX86150 ECG and PPG biosensor driver

[Md Shofiqul Islam]

Changes in v8:
- Fold MAINTAINERS entry into the driver patch; no separate patch

Changes in v7 (Jonathan Cameron's review of v5 driver):
- Switch from triggered buffer to kfifo buffer (like MAX30100/MAX30102)
  and remove the IIO trigger framework from this driver entirely
- Remove spurious 'select IIO_TRIGGER' added to AFE4403, AFE4404,
  MAX30100, MAX30102 in the Kconfig patch
- Rename all register field macros to include the parent register name
  and a _MASK suffix (e.g. MAX86150_PPG_CONFIG1_ADC_RGE_MASK)
- Use IIO_DMA_MINALIGN instead of ARCH_DMA_MINALIGN
- Use IIO_DECLARE_BUFFER_WITH_TS() macro for the push buffer
- Fix regmap_noinc_read() length: use MAX86150_SAMPLE_BYTES (9) not
  sizeof(fifo_raw) (64) -- the padded size is for DMA alignment only;
  using it would over-read the FIFO by 7 extra samples per call
- Use get_unaligned_be24() with a single mask for 24-bit FIFO reads
- Use regmap_set_bits() / regmap_clear_bits() instead of regmap_update_bits
- Use iio_push_to_buffers_with_ts() (new name)
- Use fsleep() instead of usleep_range() after software reset
- Use 10 * NSEC_PER_MSEC instead of bare 10000000
- Replace if (!ret) chains with goto-based error handling
- Remove all code-section comments
- Remove forced variable declaration alignment
- Print a warning (not -ENODEV) for unexpected part ID
- Remove IRQ trigger type fallback; honour DT specification only
- Remove memset of push buffer before packing
- Drop overflow timestamp reconstruction; flush FIFO and discard samples
- Remove struct device *dev field (unused after removing trigger)
- Rename LED_PA_DEFAULT to LED_PA_50MA to make the value self-describing
- Remove vref regulator (not a supply pin per the datasheet); keep vdd
  and vled; change to non-optional devm_regulator_get_enable()

Changes in v6 (Jonathan Cameron's review of v5 DT binding):
- Remove SoC from description; spell out photoplethysmography (PPG)
  and electrocardiogram (ECG) in full
- Remove the I2C fast-mode (400 kHz) line
- Simplify interrupt description to a single sentence

Changes in v5:
- Rebase on iio/testing
- Adjust FIFO slot descriptor defines
- Fix scan_type for ECG (signed 18-bit)

v4 and earlier: initial submission and review iterations

Md Shofiqul Islam (2):
  dt-bindings: iio: health: add adi,max86150
  iio: health: add MAX86150 ECG and PPG biosensor driver

 .../bindings/iio/health/adi,max86150.yaml     |  65 +++
 MAINTAINERS                                   |   7 +
 drivers/iio/health/Kconfig                    |  18 +
 drivers/iio/health/Makefile                   |   1 +
 drivers/iio/health/max86150.c                 | 533 ++++++++++++++++++
 5 files changed, 624 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/health/adi,max86150.yaml
 create mode 100644 drivers/iio/health/max86150.c

-- 
2.51.1

Re: [PATCH v8 0/2] iio: health: add MAX86150 ECG and PPG biosensor driver

[Andy Shevchenko]

On Tue, Jul 07, 2026 at 01:42:32PM +0300, Md Shofiqul Islam wrote:
> Changes in v8:
> - Fold MAINTAINERS entry into the driver patch; no separate patch

All three emails were sent as standalone and not in a properly chained series.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v8 0/2] iio: health: add MAX86150 ECG and PPG biosensor driver

[Andy Shevchenko]

On Tue, Jul 07, 2026 at 04:10:26PM +0300, Andy Shevchenko wrote:
> On Tue, Jul 07, 2026 at 01:42:32PM +0300, Md Shofiqul Islam wrote:
> > Changes in v8:
> > - Fold MAINTAINERS entry into the driver patch; no separate patch
> 
> All three emails were sent as standalone and not in a properly chained series.

Besides that, where are the links to the previous versions (to lore.kernel.org
archive)?

-- 
With Best Regards,
Andy Shevchenko