From: sashiko-bot@kernel.org
To: "Md Shofiqul Islam" <shofiqtest@gmail.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v9 1/2] dt-bindings: iio: health: add adi,max86150
Date: Tue, 07 Jul 2026 11:33:09 +0000 [thread overview]
Message-ID: <20260707113309.EA43D1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260707112714.2261727-2-shofiqtest@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new MAINTAINERS section 'MAX86150 ECG AND PPG BIOSENSOR DRIVER' is placed out of alphabetical order.
--
--- Patch [1]: [PATCH v9 1/2] dt-bindings: iio: health: add adi,max86150 ---
commit 5abdccc1a1cc20780d9daca161bb926907771020
Author: Md Shofiqul Islam <shofiqtest@gmail.com>
dt-bindings: iio: health: add adi,max86150
This commit adds the Device Tree binding schema for the Analog Devices
MAX86150 integrated ECG and PPG biosensor. It also adds a corresponding
entry to the MAINTAINERS file.
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a92290fffa163..436c86d6e5dfa 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
[ ... ]
> @@ -14848,6 +14848,12 @@ S: Supported
> F: Documentation/devicetree/bindings/power/supply/maxim,max77976.yaml
> F: drivers/power/supply/max77976_charger.c
>
> +MAX86150 ECG AND PPG BIOSENSOR DRIVER
> +M: Md Shofiqul Islam <shofiqtest@gmail.com>
[Severity: Low]
This isn't a bug, but is this new MAINTAINERS section placed out of
alphabetical order?
MAX86150 is inserted between MAXIM MAX77976 and MAXIM MUIC, but MAX8
should sort before MAXI in the file.
> +L: linux-iio@vger.kernel.org
> +S: Maintained
> +F: Documentation/devicetree/bindings/iio/health/adi,max86150.yaml
> +
> MAXIM MUIC CHARGER DRIVERS FOR EXYNOS BASED BOARDS
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260707112714.2261727-1-shofiqtest@gmail.com?part=1
next prev parent reply other threads:[~2026-07-07 11:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 11:27 [PATCH v9 1/2] dt-bindings: iio: health: add adi,max86150 Md Shofiqul Islam
2026-07-07 11:33 ` sashiko-bot [this message]
2026-07-07 11:45 ` Krzysztof Kozlowski
2026-07-09 7:18 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260707113309.EA43D1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shofiqtest@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox