* [PATCH v9 1/2] dt-bindings: iio: health: add adi,max86150
@ 2026-07-07 11:27 Md Shofiqul Islam
2026-07-07 11:33 ` sashiko-bot
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Md Shofiqul Islam @ 2026-07-07 11:27 UTC (permalink / raw)
To: linux-iio
Cc: jic23, devicetree, robh, krzk+dt, conor+dt, andriy.shevchenko,
u.kleine-koenig, joshua.crofts1
Add Device Tree binding schema for the Analog Devices MAX86150
integrated ECG and PPG biosensor.
The device exposes two PPG channels (Red LED and IR LED) and one ECG
channel over I2C, with a 32-entry hardware FIFO and an active-low
interrupt.
Signed-off-by: Md Shofiqul Islam <shofiqtest@gmail.com>
---
.../bindings/iio/health/adi,max86150.yaml | 65 +++++++++++++++++++
MAINTAINERS | 6 ++
2 files changed, 71 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/health/adi,max86150.yaml
diff --git a/Documentation/devicetree/bindings/iio/health/adi,max86150.yaml b/Documentation/devicetree/bindings/iio/health/adi,max86150.yaml
new file mode 100644
index 0000000000000..b0ae7d2ecfcec
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/health/adi,max86150.yaml
@@ -0,0 +1,65 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/health/adi,max86150.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Analog Devices MAX86150 ECG and PPG Biosensor
+
+maintainers:
+ - Md Shofiqul Islam <shofiqtest@gmail.com>
+
+description: |
+ The MAX86150 is an integrated biosensor that combines two
+ photoplethysmography (PPG) channels (Red LED and IR LED) and one
+ electrocardiogram (ECG) channel for biopotential recording. Samples
+ are buffered in a 32-entry hardware FIFO with a configurable
+ almost-full interrupt.
+
+ Datasheet:
+ https://www.analog.com/media/en/technical-documentation/data-sheets/MAX86150.pdf
+
+properties:
+ compatible:
+ const: adi,max86150
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+ description:
+ Interrupt line, asserted when the FIFO almost-full threshold is
+ reached.
+
+ vdd-supply:
+ description: VDD power supply (1.8 V).
+
+ vled-supply:
+ description: VLED LED anode supply (3.3 V to 5 V).
+
+required:
+ - compatible
+ - reg
+ - vdd-supply
+ - vled-supply
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ heart-rate@5e {
+ compatible = "adi,max86150";
+ reg = <0x5e>;
+ interrupt-parent = <&gpio1>;
+ interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
+ vdd-supply = <&vdd_1v8>;
+ vled-supply = <&vdd_3v3>;
+ };
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index 3115538ce8291..e9b9fd619bd86 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15863,6 +15863,12 @@ S: Supported
F: Documentation/devicetree/bindings/power/supply/maxim,max77976.yaml
F: drivers/power/supply/max77976_charger.c
+MAX86150 ECG AND PPG BIOSENSOR DRIVER
+M: Md Shofiqul Islam <shofiqtest@gmail.com>
+L: linux-iio@vger.kernel.org
+S: Maintained
+F: Documentation/devicetree/bindings/iio/health/adi,max86150.yaml
+
MAXIM MUIC CHARGER DRIVERS FOR EXYNOS BASED BOARDS
M: Krzysztof Kozlowski <krzk@kernel.org>
L: linux-pm@vger.kernel.org
--
2.51.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v9 1/2] dt-bindings: iio: health: add adi,max86150
2026-07-07 11:27 [PATCH v9 1/2] dt-bindings: iio: health: add adi,max86150 Md Shofiqul Islam
@ 2026-07-07 11:33 ` sashiko-bot
2026-07-07 11:45 ` Krzysztof Kozlowski
2026-07-09 7:18 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-07-07 11:33 UTC (permalink / raw)
To: Md Shofiqul Islam; +Cc: robh, conor+dt, devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new MAINTAINERS section 'MAX86150 ECG AND PPG BIOSENSOR DRIVER' is placed out of alphabetical order.
--
--- Patch [1]: [PATCH v9 1/2] dt-bindings: iio: health: add adi,max86150 ---
commit 5abdccc1a1cc20780d9daca161bb926907771020
Author: Md Shofiqul Islam <shofiqtest@gmail.com>
dt-bindings: iio: health: add adi,max86150
This commit adds the Device Tree binding schema for the Analog Devices
MAX86150 integrated ECG and PPG biosensor. It also adds a corresponding
entry to the MAINTAINERS file.
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a92290fffa163..436c86d6e5dfa 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
[ ... ]
> @@ -14848,6 +14848,12 @@ S: Supported
> F: Documentation/devicetree/bindings/power/supply/maxim,max77976.yaml
> F: drivers/power/supply/max77976_charger.c
>
> +MAX86150 ECG AND PPG BIOSENSOR DRIVER
> +M: Md Shofiqul Islam <shofiqtest@gmail.com>
[Severity: Low]
This isn't a bug, but is this new MAINTAINERS section placed out of
alphabetical order?
MAX86150 is inserted between MAXIM MAX77976 and MAXIM MUIC, but MAX8
should sort before MAXI in the file.
> +L: linux-iio@vger.kernel.org
> +S: Maintained
> +F: Documentation/devicetree/bindings/iio/health/adi,max86150.yaml
> +
> MAXIM MUIC CHARGER DRIVERS FOR EXYNOS BASED BOARDS
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260707112714.2261727-1-shofiqtest@gmail.com?part=1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v9 1/2] dt-bindings: iio: health: add adi,max86150
2026-07-07 11:27 [PATCH v9 1/2] dt-bindings: iio: health: add adi,max86150 Md Shofiqul Islam
2026-07-07 11:33 ` sashiko-bot
@ 2026-07-07 11:45 ` Krzysztof Kozlowski
2026-07-09 7:18 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-07 11:45 UTC (permalink / raw)
To: Md Shofiqul Islam, linux-iio
Cc: jic23, devicetree, robh, krzk+dt, conor+dt, andriy.shevchenko,
u.kleine-koenig, joshua.crofts1
On 07/07/2026 13:27, Md Shofiqul Islam wrote:
> Add Device Tree binding schema for the Analog Devices MAX86150
> integrated ECG and PPG biosensor.
>
> The device exposes two PPG channels (Red LED and IR LED) and one ECG
> channel over I2C, with a 32-entry hardware FIFO and an active-low
> interrupt.
>
> Signed-off-by: Md Shofiqul Islam <shofiqtest@gmail.com>
Please slow down. Now two versions sent within one hour. Before also
posting multiple times per day.
One version per 24h..
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v9 1/2] dt-bindings: iio: health: add adi,max86150
2026-07-07 11:27 [PATCH v9 1/2] dt-bindings: iio: health: add adi,max86150 Md Shofiqul Islam
2026-07-07 11:33 ` sashiko-bot
2026-07-07 11:45 ` Krzysztof Kozlowski
@ 2026-07-09 7:18 ` Krzysztof Kozlowski
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-09 7:18 UTC (permalink / raw)
To: Md Shofiqul Islam
Cc: linux-iio, jic23, devicetree, robh, krzk+dt, conor+dt,
andriy.shevchenko, u.kleine-koenig, joshua.crofts1
On Tue, Jul 07, 2026 at 02:27:13PM +0300, Md Shofiqul Islam wrote:
> Add Device Tree binding schema for the Analog Devices MAX86150
> integrated ECG and PPG biosensor.
>
> The device exposes two PPG channels (Red LED and IR LED) and one ECG
> channel over I2C, with a 32-entry hardware FIFO and an active-low
> interrupt.
>
> Signed-off-by: Md Shofiqul Islam <shofiqtest@gmail.com>
> ---
> .../bindings/iio/health/adi,max86150.yaml | 65 +++++++++++++++++++
> MAINTAINERS | 6 ++
I downloaded entire thread and... it is only patch #1. No user.
Please thread your patches correctly.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-07-09 7:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-07 11:27 [PATCH v9 1/2] dt-bindings: iio: health: add adi,max86150 Md Shofiqul Islam
2026-07-07 11:33 ` sashiko-bot
2026-07-07 11:45 ` Krzysztof Kozlowski
2026-07-09 7:18 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox