Re: [PATCH v2 7/7] arm64: dts: mediatek: mt8195: Add and use UART AP_DMA controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `apdma` node is placed out of order in the device tree file, violating the standard DT convention to sort nodes by their unit-address.
--

--- Patch [7]: [PATCH v2 7/7] arm64: dts: mediatek: mt8195: Add and use UART AP_DMA controller ---
commit a44a999701bce2338fffbb489d98050bb65e6842
Author: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

arm64: dts: mediatek: mt8195: Add and use UART AP_DMA controller

This commit adds the AP_DMA controller to the MT8195 device tree to provide
transmit and receive DMA channels for the SoC's UART controllers. The UART
nodes are updated to use these DMA channels for increased efficiency.

> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -877,6 +877,31 @@ systimer: timer@10017000 {
>  			clocks = <&clk13m>;
>  		};
>  
> +		apdma: dma-controller@10220880 {
> +			compatible = "mediatek,mt8195-uart-dma", "mediatek,mt6835-uart-dma";
> +			reg = <0 0x10220880 0 0x80>, <0 0x10220900 0 0x80>,

[ ... ]

> +			#dma-cells = <1>;
> +			dma-requests = <12>;
> +		};
> +
>  		pwrap: pwrap@10024000 {

[Severity: Low]
This isn't a bug, but should the apdma node be placed further down the file
to maintain standard Device Tree unit-address sorting? The node is at unit
address 10220880, but it is inserted here before pwrap at 10024000.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707154841.198870-1-angelogioacchino.delregno@collabora.com?part=7