Re: [PATCH 1/1] regulator: dt-bindings: Convert ltc3589.txt to yaml format

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The schema uses `additionalProperties: false` at the root but fails to document the `interrupts` property, causing valid device trees that use the PMIC interrupt to fail validation.
- [Low] The `lltc,fb-voltage-divider` property is missing from the `required` list for the `sw1`, `sw2`, `sw3`, `bb-out`, `ldo1`, and `ldo2` regulator nodes in the YAML schema.
--

--- Patch [1]: [PATCH 1/1] regulator: dt-bindings: Convert ltc3589.txt to yaml format ---
commit d75bd969ae4548dedbfaa0e3da2470b322b67662
Author: Frank Li <Frank.Li@nxp.com>

regulator: dt-bindings: Convert ltc3589.txt to yaml format
    
Convert ltc3589.txt to yaml format.

> diff --git a/Documentation/devicetree/bindings/regulator/lltc,ltc3589.yaml b/Documentation/devicetree/bindings/regulator/lltc,ltc3589.yaml
> new file mode 100644
> index 0000000000000..3bf44fbe321bc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/lltc,ltc3589.yaml

[ ... ]

> +properties:
> +  compatible:
> +    enum:
> +      - lltc,ltc3589
> +      - lltc,ltc3589-1
> +      - lltc,ltc3589-2
> +
> +  reg:
> +    maxItems: 1
> +
> +  regulators:
> +    type: object

[Severity: Medium]
Should interrupts be defined in this properties block?

The schema uses additionalProperties: false at the root level, but the driver
supports interrupts for thermal and undervoltage warnings. Will valid device
trees that specify the interrupts property fail validation without it being
explicitly allowed here?

> +    additionalProperties: false
> +
> +    patternProperties:
> +      "^(sw1|sw2|sw3|bb-out|ldo1|ldo2)$":
> +        type: object
> +        unevaluatedProperties: false
> +        $ref: regulator.yaml#
> +
> +        properties:
> +          lltc,fb-voltage-divider:

[Severity: Low]
Does lltc,fb-voltage-divider need to be added to a required list for these
regulators?

The old text binding specified this as a required property for sw1, sw2, sw3,
bb-out, ldo1, and ldo2. Without a required list in this patternProperties
block, won't device trees that omit lltc,fb-voltage-divider incorrectly pass
schema validation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707211612.2757349-1-Frank.Li@oss.nxp.com?part=1