* [PATCH 1/1] regulator: dt-bindings: Convert ltc3589.txt to yaml format
@ 2026-07-07 21:16 Frank.Li
2026-07-07 21:23 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Frank.Li @ 2026-07-07 21:16 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Frank Li,
open list:VOLTAGE AND CURRENT REGULATOR FRAMEWORK,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Cc: imx, Frank Li
From: Frank Li <Frank.Li@nxp.com>
Convert ltc3589.txt to yaml format.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
.../bindings/regulator/lltc,ltc3589.yaml | 143 ++++++++++++++++++
.../devicetree/bindings/regulator/ltc3589.txt | 99 ------------
2 files changed, 143 insertions(+), 99 deletions(-)
create mode 100644 Documentation/devicetree/bindings/regulator/lltc,ltc3589.yaml
delete mode 100644 Documentation/devicetree/bindings/regulator/ltc3589.txt
diff --git a/Documentation/devicetree/bindings/regulator/lltc,ltc3589.yaml b/Documentation/devicetree/bindings/regulator/lltc,ltc3589.yaml
new file mode 100644
index 0000000000000..3bf44fbe321bc
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/lltc,ltc3589.yaml
@@ -0,0 +1,143 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/lltc,ltc3589.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Linear Technology LTC3589 PMIC
+
+maintainers:
+ - Frank Li <Frank.li@kernel.org>
+
+description:
+ Linear Technology LTC3589, LTC3589-1 and LTC3589-2 are PMICs
+ containing three buck regulators, one boost regulator and four
+ LDO regulators.
+
+properties:
+ compatible:
+ enum:
+ - lltc,ltc3589
+ - lltc,ltc3589-1
+ - lltc,ltc3589-2
+
+ reg:
+ maxItems: 1
+
+ regulators:
+ type: object
+ additionalProperties: false
+
+ patternProperties:
+ "^(sw1|sw2|sw3|bb-out|ldo1|ldo2)$":
+ type: object
+ unevaluatedProperties: false
+ $ref: regulator.yaml#
+
+ properties:
+ lltc,fb-voltage-divider:
+ description:
+ Feedback voltage divider resistor values (R1, R2) in ohms.
+ Regulators sw1, sw2, sw3, and ldo2 can regulate the feedback
+ reference from 0.3625 V to 0.75 V in 12.5 mV steps. The output
+ voltage thus ranges between 0.3625 * (1 + R1/R2) V and
+ 0.75 * (1 + R1/R2) V. Regulators bb-out and ldo1 have a fixed
+ 0.8 V reference and thus output 0.8 * (1 + R1/R2) V. The ldo3
+ regulator is fixed to 1.8 V on LTC3589 and to 2.8 V on
+ LTC3589-1,2. The ldo4 regulator can output between 1.8 V and
+ 3.3 V on LTC3589 and between 1.2 V and 3.2 V on LTC3589-1,2 in
+ four steps. The ldo1 standby regulator can not be disabled and
+ thus should have the regulator-always-on property set.
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ items:
+ - description: R1 in ohms
+ - description: R2 in ohms.
+
+ "^(ldo3|ldo4)$":
+ type: object
+ unevaluatedProperties: false
+ $ref: regulator.yaml#
+
+required:
+ - compatible
+ - reg
+ - regulators
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmic@34 {
+ compatible = "lltc,ltc3589-1";
+ reg = <0x34>;
+
+ regulators {
+ sw1 {
+ regulator-min-microvolt = <591930>;
+ regulator-max-microvolt = <1224671>;
+ lltc,fb-voltage-divider = <100000 158000>;
+ regulator-ramp-delay = <7000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ sw2 {
+ regulator-min-microvolt = <704123>;
+ regulator-max-microvolt = <1456803>;
+ lltc,fb-voltage-divider = <180000 191000>;
+ regulator-ramp-delay = <7000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ sw3 {
+ regulator-min-microvolt = <1341250>;
+ regulator-max-microvolt = <2775000>;
+ lltc,fb-voltage-divider = <270000 100000>;
+ regulator-ramp-delay = <7000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ bb-out {
+ regulator-min-microvolt = <3387341>;
+ regulator-max-microvolt = <3387341>;
+ lltc,fb-voltage-divider = <511000 158000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo1 {
+ regulator-min-microvolt = <1306329>;
+ regulator-max-microvolt = <1306329>;
+ lltc,fb-voltage-divider = <100000 158000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo2 {
+ regulator-min-microvolt = <704123>;
+ regulator-max-microvolt = <1456806>;
+ lltc,fb-voltage-divider = <180000 191000>;
+ regulator-ramp-delay = <7000>;
+ regulator-boot-on;
+ regulator-always-on;
+ };
+
+ ldo3 {
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ regulator-boot-on;
+ };
+
+ ldo4 {
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <3200000>;
+ };
+ };
+ };
+ };
diff --git a/Documentation/devicetree/bindings/regulator/ltc3589.txt b/Documentation/devicetree/bindings/regulator/ltc3589.txt
deleted file mode 100644
index 8010530361465..0000000000000
--- a/Documentation/devicetree/bindings/regulator/ltc3589.txt
+++ /dev/null
@@ -1,99 +0,0 @@
-Linear Technology LTC3589, LTC3589-1, and LTC3589-2 8-output regulators
-
-Required properties:
-- compatible: "lltc,ltc3589", "lltc,ltc3589-1" or "lltc,ltc3589-2"
-- reg: I2C slave address
-
-Required child node:
-- regulators: Contains eight regulator child nodes sw1, sw2, sw3, bb-out,
- ldo1, ldo2, ldo3, and ldo4, specifying the initialization data as
- documented in Documentation/devicetree/bindings/regulator/regulator.txt.
-
-Each regulator is defined using the standard binding for regulators. The
-nodes for sw1, sw2, sw3, bb-out, ldo1, and ldo2 additionally need to specify
-the resistor values of their external feedback voltage dividers:
-
-Required properties (not on ldo3, ldo4):
-- lltc,fb-voltage-divider: An array of two integers containing the resistor
- values R1 and R2 of the feedback voltage divider in ohms.
-
-Regulators sw1, sw2, sw3, and ldo2 can regulate the feedback reference from
-0.3625 V to 0.75 V in 12.5 mV steps. The output voltage thus ranges between
-0.3625 * (1 + R1/R2) V and 0.75 * (1 + R1/R2) V. Regulators bb-out and ldo1
-have a fixed 0.8 V reference and thus output 0.8 * (1 + R1/R2) V. The ldo3
-regulator is fixed to 1.8 V on LTC3589 and to 2.8 V on LTC3589-1,2. The ldo4
-regulator can output between 1.8 V and 3.3 V on LTC3589 and between 1.2 V
-and 3.2 V on LTC3589-1,2 in four steps. The ldo1 standby regulator can not
-be disabled and thus should have the regulator-always-on property set.
-
-Example:
-
- ltc3589: pmic@34 {
- compatible = "lltc,ltc3589-1";
- reg = <0x34>;
-
- regulators {
- sw1_reg: sw1 {
- regulator-min-microvolt = <591930>;
- regulator-max-microvolt = <1224671>;
- lltc,fb-voltage-divider = <100000 158000>;
- regulator-ramp-delay = <7000>;
- regulator-boot-on;
- regulator-always-on;
- };
-
- sw2_reg: sw2 {
- regulator-min-microvolt = <704123>;
- regulator-max-microvolt = <1456803>;
- lltc,fb-voltage-divider = <180000 191000>;
- regulator-ramp-delay = <7000>;
- regulator-boot-on;
- regulator-always-on;
- };
-
- sw3_reg: sw3 {
- regulator-min-microvolt = <1341250>;
- regulator-max-microvolt = <2775000>;
- lltc,fb-voltage-divider = <270000 100000>;
- regulator-ramp-delay = <7000>;
- regulator-boot-on;
- regulator-always-on;
- };
-
- bb_out_reg: bb-out {
- regulator-min-microvolt = <3387341>;
- regulator-max-microvolt = <3387341>;
- lltc,fb-voltage-divider = <511000 158000>;
- regulator-boot-on;
- regulator-always-on;
- };
-
- ldo1_reg: ldo1 {
- regulator-min-microvolt = <1306329>;
- regulator-max-microvolt = <1306329>;
- lltc,fb-voltage-divider = <100000 158000>;
- regulator-boot-on;
- regulator-always-on;
- };
-
- ldo2_reg: ldo2 {
- regulator-min-microvolt = <704123>;
- regulator-max-microvolt = <1456806>;
- lltc,fb-voltage-divider = <180000 191000>;
- regulator-ramp-delay = <7000>;
- regulator-boot-on;
- regulator-always-on;
- };
-
- ldo3_reg: ldo3 {
- regulator-min-microvolt = <2800000>;
- regulator-max-microvolt = <2800000>;
- regulator-boot-on;
- };
-
- ldo4_reg: ldo4 {
- regulator-min-microvolt = <1200000>;
- regulator-max-microvolt = <3200000>;
- };
- };
- };
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] regulator: dt-bindings: Convert ltc3589.txt to yaml format
2026-07-07 21:16 [PATCH 1/1] regulator: dt-bindings: Convert ltc3589.txt to yaml format Frank.Li
@ 2026-07-07 21:23 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-07-07 21:23 UTC (permalink / raw)
To: Frank.Li; +Cc: robh, devicetree, Frank.Li, imx, conor+dt
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The schema uses `additionalProperties: false` at the root but fails to document the `interrupts` property, causing valid device trees that use the PMIC interrupt to fail validation.
- [Low] The `lltc,fb-voltage-divider` property is missing from the `required` list for the `sw1`, `sw2`, `sw3`, `bb-out`, `ldo1`, and `ldo2` regulator nodes in the YAML schema.
--
--- Patch [1]: [PATCH 1/1] regulator: dt-bindings: Convert ltc3589.txt to yaml format ---
commit d75bd969ae4548dedbfaa0e3da2470b322b67662
Author: Frank Li <Frank.Li@nxp.com>
regulator: dt-bindings: Convert ltc3589.txt to yaml format
Convert ltc3589.txt to yaml format.
> diff --git a/Documentation/devicetree/bindings/regulator/lltc,ltc3589.yaml b/Documentation/devicetree/bindings/regulator/lltc,ltc3589.yaml
> new file mode 100644
> index 0000000000000..3bf44fbe321bc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/lltc,ltc3589.yaml
[ ... ]
> +properties:
> + compatible:
> + enum:
> + - lltc,ltc3589
> + - lltc,ltc3589-1
> + - lltc,ltc3589-2
> +
> + reg:
> + maxItems: 1
> +
> + regulators:
> + type: object
[Severity: Medium]
Should interrupts be defined in this properties block?
The schema uses additionalProperties: false at the root level, but the driver
supports interrupts for thermal and undervoltage warnings. Will valid device
trees that specify the interrupts property fail validation without it being
explicitly allowed here?
> + additionalProperties: false
> +
> + patternProperties:
> + "^(sw1|sw2|sw3|bb-out|ldo1|ldo2)$":
> + type: object
> + unevaluatedProperties: false
> + $ref: regulator.yaml#
> +
> + properties:
> + lltc,fb-voltage-divider:
[Severity: Low]
Does lltc,fb-voltage-divider need to be added to a required list for these
regulators?
The old text binding specified this as a required property for sw1, sw2, sw3,
bb-out, ldo1, and ldo2. Without a required list in this patternProperties
block, won't device trees that omit lltc,fb-voltage-divider incorrectly pass
schema validation?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260707211612.2757349-1-Frank.Li@oss.nxp.com?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-07 21:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-07 21:16 [PATCH 1/1] regulator: dt-bindings: Convert ltc3589.txt to yaml format Frank.Li
2026-07-07 21:23 ` sashiko-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox