Re: [PATCH v4 08/11] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add pm8010 camera PMIC with voltage levels for IR and RGB camera

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The device tree node for PM8010 regulators (`regulators-8`) defines `vreg_l5m_2p8` (LDO5) but is missing its required parent supply `vdd-l5-supply`.
--

--- Patch [8]: [PATCH v4 08/11] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add pm8010 camera PMIC with voltage levels for IR and RGB camera ---
commit 95ca7f61e80f17280293495eaba4ba301dc9a920
Author: Bryan O'Donoghue <bryan.odonoghue@linaro.org>

arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add pm8010 camera PMIC with voltage levels for IR and RGB camera

Add voltage regulators-8 for Camera on slim7x including vreg_l1m_1p2 and
vreg_l3m_1p8.

> diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> index beb1475d7fa0c..0a8275d501f85 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts
[ ... ]
> +	regulators-8 {
> +		compatible = "qcom,pm8010-rpmh-regulators";
> +		qcom,pmic-id = "m";
> +
> +		vdd-l1-l2-supply = <&vreg_s5j_1p2>;
> +		vdd-l3-l4-supply = <&vreg_s4c_1p8>;
> +		vdd-l7-supply = <&vreg_bob1>;

[Severity: Medium]
Is vdd-l5-supply missing from this list of parent supplies?

Later in this node, vreg_l5m_2p8 is defined as ldo5, but its parent supply
dependency is not modeled here. Because vdd-l5-supply is omitted, the
regulator core will use a dummy regulator for ldo5.

If the unmodeled parent supply (which might be vreg_bob1 given the 2.8V
output) enters a low power state or is turned off by other consumers, could
ldo5 silently lose power and cause the dependent camera hardware to fail?

> +
[ ... ]
> +		vreg_l5m_2p8: ldo5 {
> +			regulator-name = "vreg_l5m_2p8";
> +			regulator-min-microvolt = <2800000>;
> +			regulator-max-microvolt = <3072000>;
> +			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> +		};
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-x1e-camss-csi2-phy-dtsi-v4-0-572348ad1b2a@linaro.org?part=8