Re: [PATCH v8 1/7] dt-bindings: clock: qcom: Move glymur TCSR to own binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `#clock-cells` and `#reset-cells` properties are omitted from the global `required` list despite the device functioning as a clock and reset provider.
--

--- Patch [1]: [PATCH v8 1/7] dt-bindings: clock: qcom: Move glymur TCSR to own binding ---
commit de86834007c0daa97a5bd5af83bbdcff6a5a2489
Author: Qiang Yu <qiang.yu@oss.qualcomm.com>

dt-bindings: clock: qcom: Move glymur TCSR to own binding

This commit splits the Glymur TCSR clock controller out into its own dedicated
device tree binding file. It documents the various VDD supply properties
required by the QREF block and marks them required via an allOf conditional.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml b/Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml
> new file mode 100644
> index 0000000000000..ec89feff89e4e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml
[ ... ]
> +        - vdda-refgen3-1p2-supply
> +        - vdda-refgen4-0p9-supply
> +        - vdda-refgen4-1p2-supply
> +
> +required:
> +  - compatible
> +  - clocks

[Severity: Medium]
Since this device functions as both a clock and reset provider, shouldn't
#clock-cells and #reset-cells be included in this global required list?

Without these properties in the required block, device tree nodes that are
missing them will silently pass schema validation, which could push failures
to runtime when dependent drivers try to parse the unconfigured resources.

> +
> +additionalProperties: false
> +
> +examples:
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-tcsr_qref_0708-v8-0-62c42b5fa269@oss.qualcomm.com?part=1