Re: [PATCH v7 2/4] arm64: dts: nuvoton: npcm845: Reorder timer0 and PECI nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch duplicates the `timer0` node instead of moving it, resulting in a duplicate node and label definition that will cause a Device Tree Compiler (DTC) error.
--

--- Patch [2]: [PATCH v7 2/4] arm64: dts: nuvoton: npcm845: Reorder timer0 and PECI nodes ---
commit 1450734310ae6f4872b7fb3d37cc7db1efd0ebca
Author: Tomer Maimon <tmaimon77@gmail.com>

arm64: dts: nuvoton: npcm845: Reorder timer0 and PECI nodes

Move the timer0 and PECI nodes so the APB children are ordered by
ascending unit address.

> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> @@ -59,15 +59,6 @@ apb {
>  			ranges = <0x0 0x0 0xf0000000 0x00300000>,
>  				<0xfff00000 0x0 0xfff00000 0x00016000>;
>  
> -			peci: peci-controller@100000 {
> -				compatible = "nuvoton,npcm845-peci";
> -				reg = <0x100000 0x1000>;
> -				interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>;
> -				clocks = <&clk NPCM8XX_CLK_APB3>;
> -				cmd-timeout-ms = <1000>;
> -				status = "disabled";
> -			};
> -
>  			timer0: timer@8000 {
>  				compatible = "nuvoton,npcm845-timer";
>  				interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;

[ ... ]

> @@ -138,6 +129,13 @@ serial6: serial@6000 {
>  				status = "disabled";
>  			};
>  
> +			timer0: timer@8000 {
> +				compatible = "nuvoton,npcm845-timer";
> +				interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
> +				reg = <0x8000 0x1C>;
> +				clocks = <&refclk>;
> +			};
> +

[Severity: Low]
Will this result in a duplicate node and label definition during dtbs
compilation?

It appears this patch adds timer0 to its new sorted location but misses
removing the original timer0 node from the top of the apb bus. This typically
causes a duplicate label error from the Device Tree Compiler.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708125352.1915040-1-tmaimon77@gmail.com?part=2