Re: [PATCH v7 4/4] arm64: dts: nuvoton: npcm845-evb: Add peripheral nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The device tree aliases for fiu1 and fiu3 are swapped, causing mismatched physical interfaces and partition labels.
--

--- Patch [4]: [PATCH v7 4/4] arm64: dts: nuvoton: npcm845-evb: Add peripheral nodes ---
commit addb487f93312d5fc6f3c9be5cafae0cfda32949
Author: Tomer Maimon <tmaimon77@gmail.com>

arm64: dts: nuvoton: npcm845-evb: Add peripheral nodes

This commit enables peripheral support for the NPCM845 evaluation board by
wiring up the SoC controller nodes to the board design. It adds board aliases,
MDIO buses, reserved memory, flash partitions, and enables various controllers.

> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts b/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts
> index 5edf5d13342da..7717c3a8f76d2 100644
> --- a/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts
> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-npcm845-evb.dts
> @@ -10,6 +10,42 @@ / {
>  
>  	aliases {
>  		serial0 = &serial0;
> +		ethernet1 = &gmac1;
> +		ethernet2 = &gmac2;
> +		ethernet3 = &gmac3;
> +		mdio-gpio0 = &mdio0;
> +		mdio-gpio1 = &mdio1;
> +		fiu0 = &fiu0;
> +		fiu1 = &fiu3;
> +		fiu2 = &fiux;
> +		fiu3 = &fiu1;

[Severity: Medium]
Are the aliases for fiu1 and fiu3 swapped here?

The underlying node for &fiu1 is labeled "spi1-system1" and &fiu3 is labeled
"spi3-system1" later in the device tree. Could this cross-wiring cause
userspace scripts or tools that rely on fixed controller IDs to write to or
read from the wrong SPI flash partition?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708125352.1915040-1-tmaimon77@gmail.com?part=4