Re: [PATCH v5 5/5] arm64: versal-net: Switch Versal NET to firmware clock interface

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Duplication of dt-bindings headers into arch/arm64/boot/dts/xilinx/ instead of include/dt-bindings/.
--

--- Patch [5]: [PATCH v5 5/5] arm64: versal-net: Switch Versal NET to firmware clock interface ---
commit 49b1e2cd1b89d937b21ae992159666e14683c5d0
Author: Michal Simek <michal.simek@amd.com>

arm64: versal-net: Switch Versal NET to firmware clock interface

This commit switches Versal NET from using fixed clocks to the
firmware-based clock interface via versal-net-clk.dtsi. It also adds new
DT macro headers for Versal NET and base Versal clocks, power domains,
and mandatory resets required by the clock dtsi.

[ ... ]

> diff --git a/arch/arm64/boot/dts/xilinx/xlnx-versal-clk.h b/arch/arm64/boot/dts/xilinx/xlnx-versal-clk.h
> new file mode 100644
> index 0000000000000..d0c4abf78f307
> --- /dev/null
> +++ b/arch/arm64/boot/dts/xilinx/xlnx-versal-clk.h
> @@ -0,0 +1,123 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (C) 2019 - 2022, Xilinx, Inc.
> + * Copyright (C) 2022 - 2026, Advanced Micro Devices, Inc.
> + */
> +
> +#ifndef _XLNX_VERSAL_CLK_H
> +#define _XLNX_VERSAL_CLK_H

[Severity: Low]
Should these device tree binding headers (like xlnx-versal-clk.h and
xlnx-versal-power.h) be placed in include/dt-bindings/ instead of the
architecture-specific DTS directory? Placing them in the arch directory
prevents drivers from easily including them and diverges from the standard
kernel tree layout for device tree bindings.

[ ... ]

> diff --git a/arch/arm64/boot/dts/xilinx/xlnx-versal-resets.h b/arch/arm64/boot/dts/xilinx/xlnx-versal-resets.h
> new file mode 100644
> index 0000000000000..fe00f4a0ba65b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/xilinx/xlnx-versal-resets.h
> @@ -0,0 +1,106 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (C) 2020 - 2022, Xilinx, Inc.
> + * Copyright (C) 2022 - 2026, Advanced Micro Devices, Inc.
> + */
> +
> +#ifndef _XLNX_VERSAL_RESETS_H
> +#define _XLNX_VERSAL_RESETS_H

[Severity: Low]
Does this file need to be added here? It appears this newly added file is
an exact duplicate of the existing
include/dt-bindings/reset/xlnx-versal-resets.h.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1783516336.git.michal.simek@amd.com?part=5