From: sashiko-bot@kernel.org
To: "Loic Poulain" <loic.poulain@oss.qualcomm.com>
Cc: lee@kernel.org, linux-leds@vger.kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v4 2/4] dt-bindings: leds: nxp,pca963x: add multicolor LED support
Date: Wed, 08 Jul 2026 14:27:28 +0000 [thread overview]
Message-ID: <20260708142728.A9E9D1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260708-monza-leds-v4-2-a7acfc524c0b@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message description is not capitalized.
--
--- Patch [2]: [PATCH v4 2/4] dt-bindings: leds: nxp,pca963x: add multicolor LED support ---
commit 30cb94bf03a6bf1ebbdadf9eba002ed180f281ee
Author: Loic Poulain <loic.poulain@oss.qualcomm.com>
dt-bindings: leds: nxp,pca963x: add multicolor LED support
This commit adds support for grouping individual PCA963x channels into a
multicolor LED by introducing a multi-led@N node pattern to model hardware
setups where multiple PWM channels drive a single physical RGB LED.
> dt-bindings: leds: nxp,pca963x: add multicolor LED support
[Severity: Low]
This isn't a bug, but the description after the subsystem prefix in the
subject line is not capitalized. The LED subsystem guidelines request
capitalizing the description (e.g., "Add multicolor LED support").
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-monza-leds-v4-0-a7acfc524c0b@oss.qualcomm.com?part=2
next prev parent reply other threads:[~2026-07-08 14:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 14:18 [PATCH v4 0/4] leds: pca963x: Add multicolor support and enable Monza RGB LEDs Loic Poulain
2026-07-08 14:19 ` [PATCH v4 1/4] dt-bindings: leds: nxp,pca963x: fix reg maximum for pca9635 Loic Poulain
2026-07-08 14:26 ` sashiko-bot
2026-07-08 16:25 ` Conor Dooley
2026-07-08 14:19 ` [PATCH v4 2/4] dt-bindings: leds: nxp,pca963x: add multicolor LED support Loic Poulain
2026-07-08 14:27 ` sashiko-bot [this message]
2026-07-08 16:27 ` Conor Dooley
2026-07-08 14:19 ` [PATCH v4 3/4] leds: pca963x: add multicolor LED class support Loic Poulain
2026-07-08 14:38 ` sashiko-bot
2026-07-08 14:19 ` [PATCH v4 4/4] arm64: dts: monaco-arduino-monza: microcontroller LEDs Loic Poulain
2026-07-08 14:30 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260708142728.A9E9D1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox