Re: [PATCH] arm64: dts: qcom: monaco-arduino-monza: Add GPIO line names

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Multiple typographical errors in GPIO line names ('SDL' instead of 'SCL', missing 'SPI' in CS name) and in the commit message.
--

--- Patch [1]: [PATCH] arm64: dts: qcom: monaco-arduino-monza: Add GPIO line names ---
commit f90079e8b747e78feb067474d4b03223eaab361c
Author: Loic Poulain <loic.poulain@oss.qualcomm.com>

arm64: dts: qcom: monaco-arduino-monza: Add GPIO line names

This commit adds gpio-line-names to the tlmm node in the monaco-arduino-monza
device tree. It documents the pin functions for various headers, flat connectors,
and the SoC-to-MCU interface on the VENTUNO Q board.

>     Add gpio-line-names to the tlmm node to document the PIN functions on
>     on the VENTUNO Q board. This covers the different headers (JMISC, JHAT,

[Severity: Medium]
This isn't a bug, but there's a typo ("on on") in the commit message.

> diff --git a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> index 8b3ed73feb6ec..24d2704666745 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> @@ -426,6 +426,34 @@ &pcieport1 {
>  };
>  
>  &tlmm {
> +	gpio-line-names = "", "", "", "", "",
> +			  "", "", "", "", "",
> +			  "JMISC_SPI_MISO", "JMISC_SPI_MOSI", "JMISC_SPI_SCK", "JMISC_SPI_CS0", "JMISC_SPI_CS1",
> +			  "JMISC_CS2", "", "JHAT_P03_I2C_SDA", "JHAT_P05_I2C_SCL", "JHAT_P27_EEPROM_SDA",
> +			  "JHAT_P28_EEPROM_SDL", "", "", "", "",

[Severity: Medium]
Should "JMISC_CS2" include the "SPI_" prefix to match the adjacent CS0 and CS1
lines?

Is "JHAT_P28_EEPROM_SDL" a typo for "JHAT_P28_EEPROM_SCL"?

> +			  "JHAT_P21_SPI_MISO", "JHAT_P19_SPI_MOSI", "JHAT_P23_SPI_SCLK", "JHAT_P24_SPI_CE0", "",
> +			  "", "MCU_I2C1_SDA", "MCU_I2C1_SDL", "", "",

[Severity: Medium]
Is "MCU_I2C1_SDL" also a typo for "MCU_I2C1_SCL"?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-gpio-names-v1-1-9162105b9971@oss.qualcomm.com?part=1