Devicetree
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: qcom: monaco-arduino-monza: Add GPIO line names
@ 2026-07-08 15:34 Loic Poulain
  2026-07-08 15:40 ` sashiko-bot
  2026-07-08 15:47 ` Dmitry Baryshkov
  0 siblings, 2 replies; 3+ messages in thread
From: Loic Poulain @ 2026-07-08 15:34 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Loic Poulain

Add gpio-line-names to the tlmm node to document the PIN functions on
on the VENTUNO Q board. This covers the different headers (JMISC, JHAT,
JOMEGA and JCTL), the flat connectors, and the SoC-to-MCU interface.

Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts | 28 +++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
index 8b3ed73feb6eca6578382beca588baf42b8c9bb6..24d27046667450bf3aea7646d352fe27f0a64867 100644
--- a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
+++ b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
@@ -426,6 +426,34 @@ &pcieport1 {
 };
 
 &tlmm {
+	gpio-line-names = "", "", "", "", "",
+			  "", "", "", "", "",
+			  "JMISC_SPI_MISO", "JMISC_SPI_MOSI", "JMISC_SPI_SCK", "JMISC_SPI_CS0", "JMISC_SPI_CS1",
+			  "JMISC_CS2", "", "JHAT_P03_I2C_SDA", "JHAT_P05_I2C_SCL", "JHAT_P27_EEPROM_SDA",
+			  "JHAT_P28_EEPROM_SDL", "", "", "", "",
+			  "JHAT_P21_SPI_MISO", "JHAT_P19_SPI_MOSI", "JHAT_P23_SPI_SCLK", "JHAT_P24_SPI_CE0", "",
+			  "", "MCU_I2C1_SDA", "MCU_I2C1_SDL", "", "",
+			  "", "", "JOMEGA_SPI_SCK", "JOMEGA_SPI_CS", "JOMEGA_SPI_MISO",
+			  "JOMEGA_SPI_MOSI", "", "MCU_PG11", "JCTL_UART_DBG_TX", "JCTL_UART_DBG_RX",
+			  "", "", "MCU_BOOT0", "CYPD_SWCLK", "",
+			  "", "", "FORCE_USB_BOOT", "", "",
+			  "", "", "JMEDIA_SOC_CC0_SDA", "JMEDIA_SOC_CC0_SCL", "JMEDIA_SOC_CC1_SDA",
+			  "JMEDIA_SOC_CC1_SCL", "", "", "MCU_PG12", "",
+			  "FLAT0_P17_GPIO", "", "JMEDIA_SOC_CAM_MCLK0", "JMEDIA_SOC_CAM_MCLK1", "MCU_PG9",
+			  "MCU_PA13_SWDIO", "MCU_PA14_SWCLK", "", "JMISC_SOC_GPIO_0", "JMISC_SOC_GPIO_1",
+			  "FLAT1_P17_GPIO", "", "JHAT_P32_PWM0", "MCU_NRST", "USER_BUTTON",
+			  "JHAT_P31_GPIO", "JHAT_P33_GPIO",  "FLAT2_P17_GPIO", "JHAT_P07_GPCLK0", "JHAT_P36_UART_CTS",
+			  "JHAT_P11_UART_RFR", "JHAT_P08_UART_TX", "JHAT_P10_UART_RX", "JHAT_P26_SPI_CE1", "JHAT_P29_GPIO",
+			  "JHAT_P15_GPIO", "", "MCU_PG10", "", "CYPD_SWDIO",
+			  "MCU_PG13", "MCU_PG14", "", "", "",
+			  "", "", "", "", "CYPD_NRES",
+			  "JHAT_P16_GPIO", "JHAT_P18_GPIO", "JHAT_P22_GPIO", "JHAT_P37_GPIO", "JHAT_P13_GPIO",
+			  "", "", "", "", "",
+			  "", "JHAT_P12_PCM_CLK", "JHAT_P35_PCM_FS", "JHAT_P38_PCM_DIN", "JHAT_P40_PCM_DOUT",
+			  "", "", "", "", "",
+			  "", "", "", "", "",
+			  "", "", "";
+
 	pcie0_default_state: pcie0-default-state {
 		wake-pins {
 			pins = "gpio0";

---
base-commit: f86573e68e56a7df7d54eb58101ac413ba731996
change-id: 20260708-gpio-names-50eb3a4f16d7

Best regards,
-- 
Loic Poulain <loic.poulain@oss.qualcomm.com>


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: monaco-arduino-monza: Add GPIO line names
  2026-07-08 15:34 [PATCH] arm64: dts: qcom: monaco-arduino-monza: Add GPIO line names Loic Poulain
@ 2026-07-08 15:40 ` sashiko-bot
  2026-07-08 15:47 ` Dmitry Baryshkov
  1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-07-08 15:40 UTC (permalink / raw)
  To: Loic Poulain; +Cc: robh, devicetree, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Multiple typographical errors in GPIO line names ('SDL' instead of 'SCL', missing 'SPI' in CS name) and in the commit message.
--

--- Patch [1]: [PATCH] arm64: dts: qcom: monaco-arduino-monza: Add GPIO line names ---
commit f90079e8b747e78feb067474d4b03223eaab361c
Author: Loic Poulain <loic.poulain@oss.qualcomm.com>

arm64: dts: qcom: monaco-arduino-monza: Add GPIO line names

This commit adds gpio-line-names to the tlmm node in the monaco-arduino-monza
device tree. It documents the pin functions for various headers, flat connectors,
and the SoC-to-MCU interface on the VENTUNO Q board.

>     Add gpio-line-names to the tlmm node to document the PIN functions on
>     on the VENTUNO Q board. This covers the different headers (JMISC, JHAT,

[Severity: Medium]
This isn't a bug, but there's a typo ("on on") in the commit message.

> diff --git a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> index 8b3ed73feb6ec..24d2704666745 100644
> --- a/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> +++ b/arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts
> @@ -426,6 +426,34 @@ &pcieport1 {
>  };
>  
>  &tlmm {
> +	gpio-line-names = "", "", "", "", "",
> +			  "", "", "", "", "",
> +			  "JMISC_SPI_MISO", "JMISC_SPI_MOSI", "JMISC_SPI_SCK", "JMISC_SPI_CS0", "JMISC_SPI_CS1",
> +			  "JMISC_CS2", "", "JHAT_P03_I2C_SDA", "JHAT_P05_I2C_SCL", "JHAT_P27_EEPROM_SDA",
> +			  "JHAT_P28_EEPROM_SDL", "", "", "", "",

[Severity: Medium]
Should "JMISC_CS2" include the "SPI_" prefix to match the adjacent CS0 and CS1
lines?

Is "JHAT_P28_EEPROM_SDL" a typo for "JHAT_P28_EEPROM_SCL"?

> +			  "JHAT_P21_SPI_MISO", "JHAT_P19_SPI_MOSI", "JHAT_P23_SPI_SCLK", "JHAT_P24_SPI_CE0", "",
> +			  "", "MCU_I2C1_SDA", "MCU_I2C1_SDL", "", "",

[Severity: Medium]
Is "MCU_I2C1_SDL" also a typo for "MCU_I2C1_SCL"?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-gpio-names-v1-1-9162105b9971@oss.qualcomm.com?part=1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] arm64: dts: qcom: monaco-arduino-monza: Add GPIO line names
  2026-07-08 15:34 [PATCH] arm64: dts: qcom: monaco-arduino-monza: Add GPIO line names Loic Poulain
  2026-07-08 15:40 ` sashiko-bot
@ 2026-07-08 15:47 ` Dmitry Baryshkov
  1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2026-07-08 15:47 UTC (permalink / raw)
  To: Loic Poulain
  Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, linux-arm-msm, devicetree, linux-kernel

On Wed, Jul 08, 2026 at 05:34:21PM +0200, Loic Poulain wrote:
> Add gpio-line-names to the tlmm node to document the PIN functions on
> on the VENTUNO Q board. This covers the different headers (JMISC, JHAT,
> JOMEGA and JCTL), the flat connectors, and the SoC-to-MCU interface.
> 
> Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/monaco-arduino-monza.dts | 28 +++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>


-- 
With best wishes
Dmitry

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-07-08 15:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-08 15:34 [PATCH] arm64: dts: qcom: monaco-arduino-monza: Add GPIO line names Loic Poulain
2026-07-08 15:40 ` sashiko-bot
2026-07-08 15:47 ` Dmitry Baryshkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox