Re: [PATCH 4/5] dt-bindings: display: panel: add compatible for DCLTek 300250 9.35in panel

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The newly added compatible string `dcltek,dt300250` will not be probed by the panel driver due to missing `of_match_table` entry.
- [Low] Redundant assignment of `jadard->panel.prepare_prev_first = true;`.
--

--- Patch [4]: [PATCH 4/5] dt-bindings: display: panel: add compatible for DCLTek 300250 9.35in panel ---
commit eaec789ca9baff9cff690aca5a539d1f1eb81d5f
Author: Marc-Olivier Champagne <marc-olivier.champagne@savoirfairelinux.com>

dt-bindings: display: panel: add compatible for DCLTek 300250 9.35in panel

The DCLTek dt300250 is a panel using the jadard-jd9365da controller.
Add a new compatible for it.

> diff --git a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
> index 4eae802de9fd5..9e20e2faf82fa 100644
> --- a/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/jadard,jd9365da-h3.yaml
> @@ -19,6 +19,7 @@ properties:
>            - anbernic,rg-ds-display-bottom
>            - anbernic,rg-ds-display-top
>            - chongzhou,cz101b4001
> +          - dcltek,dt300250

[Severity: Medium]
Will the panel driver successfully bind to this new compatible string?

Looking at jadard_of_match in drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c,
it seems neither this new compatible string nor a generic fallback is present
in the match table:

drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c:jadard_of_match[] = {
    {
        .compatible = "anbernic,rg-ds-display-bottom",
        ...

Without a matching entry in the of_match_table, does this regression cause
the device to fail to probe?


[Severity: Low]
Looking at the driver changes introduced earlier in this series by commit
1a793dbc7476, is there a redundant assignment to prepare_prev_first?

drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c:jadard_dsi_probe() {
    ...
    jadard->panel.prepare_prev_first = true;
    ...
    jadard->panel.prepare_prev_first = true;
    ...
}

Could this regression be a duplicated assignment in the same function?

>            - kingdisplay,kd101ne3-40ti
>            - melfas,lmfbx101117480
>            - radxa,display-10hd-ad001

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708213500.1867092-1-marc-olivier.champagne@savoirfairelinux.com?part=4