[PATCHv2 0/3] ARM: dts: helios4: add regulator supplies

[PATCHv2 0/3] ARM: dts: helios4: add regulator supplies

[Rosen Penev]

This series adds missing vcc-supply properties to the EEPROM and GPIO
expander on the Helios4, adds SATA regulator supplies.

v2: remove thermal patch

Rosen Penev (3):
  ARM: dts: helios4: add vcc-supply to EEPROM
  ARM: dts: helios4: add vcc-supply to GPIO expander
  ARM: dts: helios4: add SATA regulator supplies

 arch/arm/boot/dts/marvell/armada-388-helios4.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

-- 
2.55.0

[PATCHv2 1/3] ARM: dts: helios4: add vcc-supply to EEPROM

[Rosen Penev]

The at24 driver requests a 'vcc' supply for the EEPROM, producing
'supply vcc not found, using dummy regulator' at boot when the
property is missing.

The EEPROM sits on the Helios 4 and is powered by the
same always-on 3.3V rail used by other on-board I2C devices.
Add vcc-supply = <&reg_3p3v> to silence the warning.

Fixes: ced8025b569e ("ARM: dts: armada388-helios4")
Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 arch/arm/boot/dts/marvell/armada-388-helios4.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
index 390e98df49c9..05540b8012c2 100644
--- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
+++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
@@ -201,6 +201,10 @@ temp_sensor: temp@4c {
 					reg = <0x4c>;
 					vcc-supply = <&reg_3p3v>;
 				};
+
+				eeprom@53 {
+					vcc-supply = <&reg_3p3v>;
+				};
 			};
 
 			i2c@11100 {
-- 
2.55.0

[PATCHv2 2/3] ARM: dts: helios4: add vcc-supply to GPIO expander

[Rosen Penev]

The pca953x driver requests a 'vcc' supply, producing:
  pca953x 0-0020: supply vcc not found, using dummy regulator

The PCA9655 (PCA9555-compatible) expander is powered by the same
always-on 3.3V rail as the other I2C devices on the bus.  Add
vcc-supply = <&reg_3p3v> to silence the warning.

Fixes: ced8025b569e ("ARM: dts: armada388-helios4")
Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 arch/arm/boot/dts/marvell/armada-388-helios4.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
index 05540b8012c2..cf0432a0e71a 100644
--- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
+++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
@@ -169,6 +169,7 @@ expander0: gpio-expander@20 {
 					gpio-controller;
 					#gpio-cells = <2>;
 					reg = <0x20>;
+					vcc-supply = <&reg_3p3v>;
 					pinctrl-names = "default";
 					pinctrl-0 = <&pca0_pins>;
 					interrupt-parent = <&gpio0>;
-- 
2.55.0

[PATCHv2 3/3] ARM: dts: helios4: add SATA regulator supplies

[Rosen Penev]

The ahci-mvebu driver and libahci_platform request three supplies
on SATA controller and port nodes:
  - ahci-supply  (controller power)
  - phy-supply   (PHY power)
  - target-supply (disk power per port)

Without them the regulator core prints notices at boot, e.g.:
  supply ahci not found, using dummy regulator
  supply phy not found, using dummy regulator
  supply target not found, using dummy regulator

The SATA controller and PHY inside the Armada 388 SoC are powered
by the 3.3V I/O rail; the four disk bays are powered by the 5V HDD
rail.  Wire the existing fixed regulators accordingly.

Fixes: ced8025b569e ("ARM: dts: armada388-helios4")
Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 arch/arm/boot/dts/marvell/armada-388-helios4.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
index cf0432a0e71a..626a7339a5d0 100644
--- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
+++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
@@ -222,13 +222,17 @@ sata@a8000 {
 				status = "okay";
 				#address-cells = <1>;
 				#size-cells = <0>;
+				ahci-supply = <&reg_3p3v>;
+				phy-supply = <&reg_3p3v>;
 
 				sata0: sata-port@0 {
 					reg = <0>;
+					target-supply = <&reg_5p0v_hdd>;
 				};
 
 				sata1: sata-port@1 {
 					reg = <1>;
+					target-supply = <&reg_5p0v_hdd>;
 				};
 			};
 
@@ -236,13 +240,17 @@ sata@e0000 {
 				status = "okay";
 				#address-cells = <1>;
 				#size-cells = <0>;
+				ahci-supply = <&reg_3p3v>;
+				phy-supply = <&reg_3p3v>;
 
 				sata2: sata-port@0 {
 					reg = <0>;
+					target-supply = <&reg_5p0v_hdd>;
 				};
 
 				sata3: sata-port@1 {
 					reg = <1>;
+					target-supply = <&reg_5p0v_hdd>;
 				};
 			};
 
-- 
2.55.0

Re: [PATCHv2 3/3] ARM: dts: helios4: add SATA regulator supplies

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The struct device reference acquired by of_find_device_by_node() is never released, causing a memory leak.
--

--- Patch [1]: [PATCHv2 3/3] ARM: dts: helios4: add SATA regulator supplies ---
commit 737d149c64d97348e97b79fed6b2378d4f1a140f
Author: Rosen Penev <rosenp@gmail.com>

ARM: dts: helios4: add SATA regulator supplies

The ahci-mvebu driver and libahci_platform request three supplies
on SATA controller and port nodes to avoid regulator core boot notices.
The SATA controller and PHY are powered by the 3.3V I/O rail, while the
four disk bays are powered by the 5V HDD rail.

> diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> index ec134e22bae3e..af1e81638f829 100644
> --- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> +++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> @@ -217,13 +217,17 @@ sata@a8000 {
>  				status = "okay";
>  				#address-cells = <1>;
>  				#size-cells = <0>;
> +				ahci-supply = <&reg_3p3v>;
> +				phy-supply = <&reg_3p3v>;
>  
>  				sata0: sata-port@0 {
>  					reg = <0>;
> +					target-supply = <&reg_5p0v_hdd>;

[Severity: High]
This is a pre-existing issue and was not introduced by this patch, but doesn't
adding these supplies increase the chance of memory leaks during probe
deferrals?

In drivers/ata/libahci_platform.c:ahci_platform_get_resources(), the device
reference acquired by of_find_device_by_node() is never released:

			port_dev = of_find_device_by_node(child);

			if (port_dev) {
				rc = ahci_platform_get_regulator(hpriv, port,
								&port_dev->dev);
				if (rc == -EPROBE_DEFER)
					goto err_out;
			}

If the newly added target-supply regulators return -EPROBE_DEFER, the probe
fails and is retried. This unconditionally leaks a struct platform_device
reference on every retry because put_device() is never called for port_dev.

>  				};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709005005.1587852-4-rosenp@gmail.com?part=1

Re: [PATCHv2 3/3] ARM: dts: helios4: add SATA regulator supplies

[Rosen Penev]

On Wed, Jul 8, 2026 at 6:02 PM <sashiko-bot@kernel.org> wrote:
>
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
>
> Pre-existing issues:
> - [High] The struct device reference acquired by of_find_device_by_node() is never released, causing a memory leak.
Not relevant.
> --
>
> --- Patch [1]: [PATCHv2 3/3] ARM: dts: helios4: add SATA regulator supplies ---
> commit 737d149c64d97348e97b79fed6b2378d4f1a140f
> Author: Rosen Penev <rosenp@gmail.com>
>
> ARM: dts: helios4: add SATA regulator supplies
>
> The ahci-mvebu driver and libahci_platform request three supplies
> on SATA controller and port nodes to avoid regulator core boot notices.
> The SATA controller and PHY are powered by the 3.3V I/O rail, while the
> four disk bays are powered by the 5V HDD rail.
>
> > diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> > index ec134e22bae3e..af1e81638f829 100644
> > --- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> > +++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> > @@ -217,13 +217,17 @@ sata@a8000 {
> >                               status = "okay";
> >                               #address-cells = <1>;
> >                               #size-cells = <0>;
> > +                             ahci-supply = <&reg_3p3v>;
> > +                             phy-supply = <&reg_3p3v>;
> >
> >                               sata0: sata-port@0 {
> >                                       reg = <0>;
> > +                                     target-supply = <&reg_5p0v_hdd>;
>
> [Severity: High]
> This is a pre-existing issue and was not introduced by this patch, but doesn't
> adding these supplies increase the chance of memory leaks during probe
> deferrals?
>
> In drivers/ata/libahci_platform.c:ahci_platform_get_resources(), the device
> reference acquired by of_find_device_by_node() is never released:
>
>                         port_dev = of_find_device_by_node(child);
>
>                         if (port_dev) {
>                                 rc = ahci_platform_get_regulator(hpriv, port,
>                                                                 &port_dev->dev);
>                                 if (rc == -EPROBE_DEFER)
>                                         goto err_out;
>                         }
>
> If the newly added target-supply regulators return -EPROBE_DEFER, the probe
> fails and is retried. This unconditionally leaks a struct platform_device
> reference on every retry because put_device() is never called for port_dev.
>
> >                               };
>
> --
> Sashiko AI review · https://sashiko.dev/#/patchset/20260709005005.1587852-4-rosenp@gmail.com?part=1