Re: [PATCH v2 2/3] arm64: dts: qcom: kaanapali-qrd: Add SoCCP node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The board-specific `&remoteproc_soccp` node is missing the `status = "okay";` property, relying on a flawed default in the base device tree.
--

--- Patch [2]: [PATCH v2 2/3] arm64: dts: qcom: kaanapali-qrd: Add SoCCP node ---
commit 499497fe00069ecefb1bec759006b9907810f4e3
Author: Jingyi Wang <jingyi.wang@oss.qualcomm.com>

arm64: dts: qcom: kaanapali-qrd: Add SoCCP node

This commit adds the remote processor firmware configuration for the SoCCP
node on the Kaanapali QRD board.

> diff --git a/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts b/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts
> index 55d02219ef4e9..8ac1c664a7fd4 100644
> --- a/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts
> +++ b/arch/arm64/boot/dts/qcom/kaanapali-qrd.dts

[ ... ]

> @@ -786,6 +786,11 @@ &remoteproc_cdsp {
>  	status = "okay";
>  };
>  
> +&remoteproc_soccp {
> +	firmware-name = "qcom/kaanapali/soccp.mbn",
> +			"qcom/kaanapali/soccp_dtb.mbn";
> +};

[Severity: Medium]
Should this node explicitly include a status = "okay"; property?

While the node might currently function if the base kaanapali.dtsi omitted
a status = "disabled"; declaration, standard Qualcomm remoteproc conventions
typically disable remote processors by default in the base device tree.

If the base device tree is later corrected to follow this convention, the
SoCCP could silently become disabled on this board because it lacks an
explicit enable here.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-knp-soccp-dt-v2-0-6e2bfca96088@oss.qualcomm.com?part=2