Re: [PATCH v5 2/6] Bluetooth: btqca: Add IPQ5018 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] Incomplete implementation resulting in dead code: the QCA_IPQ5018 SoC type is not mapped in any device tree match table.
- [High] The implementation unconditionally skips downloading the required rampatch firmware `qca/bt_fw_patch.mbn`.
--

--- Patch [2]: [PATCH v5 2/6] Bluetooth: btqca: Add IPQ5018 support ---
commit 388a60ab03a30caa9b4a4e153c1ccb4a83f4283c
Author: George Moussalem <george.moussalem@outlook.com>

Bluetooth: btqca: Add IPQ5018 support

This commit adds the IPQ5018 SoC type and support for loading its firmware
for Bluetooth support.

> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> index 22b08ab05b829..f5ded8fb1e3ab 100644
> --- a/drivers/bluetooth/btqca.c
> +++ b/drivers/bluetooth/btqca.c
> @@ -775,6 +778,9 @@ int qca_uart_setup(struct hci_dev *hdev, uint8_t baudrate,
>  	else
>  		rom_ver = ((soc_ver & 0x00000f00) >> 0x04) | (soc_ver & 0x0000000f);
>  
> +	if (soc_type == QCA_IPQ5018)
> +		goto download_nvm;
> +

[Severity: High]
The commit message explicitly states that qca/bt_fw_patch.mbn is needed,
but doesn't this goto statement unconditionally skip the entire rampatch
download block?

If a firmware-name is provided via the device tree, it appears it would
also be incorrectly loaded as the NVM configuration instead of the rampatch
due to this jump.

[ ... ]

> diff --git a/drivers/bluetooth/btqca.h b/drivers/bluetooth/btqca.h
> index 8f3c1b1c77b3d..343cd62d11371 100644
> --- a/drivers/bluetooth/btqca.h
> +++ b/drivers/bluetooth/btqca.h
> @@ -158,6 +160,7 @@ enum qca_btsoc_type {
>  	QCA_WCN6750,
>  	QCA_WCN6855,
>  	QCA_WCN7850,
> +	QCA_IPQ5018,
>  };

[Severity: High]
Is there a missing device tree match mapping for QCA_IPQ5018 in hci_qca.c?

Without adding an entry like qcom,ipq5018-bt to qca_bluetooth_of_match,
it seems the driver will never probe the device and soc_type will never
be set to QCA_IPQ5018. This would make the newly added firmware loading
logic completely unreachable.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-ipq5018-bluetooth-v5-0-e476c41f03b8@outlook.com?part=2