Re: [PATCH v4 05/14] usb: hub: Associate port@ fwnode with USB port device

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces an unused local variable `hdev` in `usb_hub_remove_port_device`.
--

--- Patch [5]: [PATCH v4 05/14] usb: hub: Associate port@ fwnode with USB port device ---
commit 99d7e99ad957a10ca942a12622a4b31eeee25785
Author: Chen-Yu Tsai <wenst@chromium.org>

usb: hub: Associate port@ fwnode with USB port device

This commit associates a USB port's firmware node with the USB port device
unless the hub's firmware node is an ACPI node. This supports matching the
requesting port in later changes for the M.2 slot power sequencing provider.

> diff --git a/drivers/usb/core/port.c b/drivers/usb/core/port.c
> index b1364f0c384ce..e8fb2acd77bef 100644
> --- a/drivers/usb/core/port.c
> +++ b/drivers/usb/core/port.c

[ ... ]

> @@ -852,6 +865,7 @@ int usb_hub_create_port_device(struct usb_hub *hub, int port1)
>  
>  void usb_hub_remove_port_device(struct usb_hub *hub, int port1)
>  {
> +	struct usb_device *hdev = hub->hdev;

[Severity: Low]
Is hdev used anywhere else in usb_hub_remove_port_device()? It appears to be
declared and initialized here but never referenced, which might trigger a
compiler warning for an unused variable when building with CONFIG_WERROR.

>  	struct usb_port *port_dev = hub->ports[port1 - 1];
>  	struct usb_port *peer;
>

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709095726.704448-1-wenst@chromium.org?part=5