Re: [PATCH v4 13/14] arm64: dts: mediatek: mt8195-cherry: Add M.2 E-key slot

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Wake-on-WLAN (WoWLAN) is broken due to the removal of the `wakeup-source` property.
--

--- Patch [13]: [PATCH v4 13/14] arm64: dts: mediatek: mt8195-cherry: Add M.2 E-key slot ---
commit d236ad7145736f4079f93e3a3bc9ca160b9f82df
Author: Chen-Yu Tsai <wenst@chromium.org>

arm64: dts: mediatek: mt8195-cherry: Add M.2 E-key slot

The Mt8195 Cherry design features an M.2 E-key slot for WiFi/BT combo
cards. This patch adds the proper representation for it, replacing the PCIe
wifi node and vpcie3v3-supply property under the PCIe controller.

> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> index ef7afc436aefc..8d4cc30d91e44 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi

[ ... ]

> @@ -791,14 +832,14 @@ pcie@0 {
>  		reg = <0 0 0 0 0>;
>  		device_type = "pci";
>  		num-lanes = <1>;
> -		vpcie3v3-supply = <&pp3300_wlan>;
>  		#address-cells = <3>;
>  		#size-cells = <2>;
>  		ranges;
>  
> -		wifi@0 {
> -			reg = <0 0 0 0 0>;
> -			wakeup-source;

[Severity: Medium]
Will the removal of the wakeup-source property break Wake-on-WLAN for this
device?

The MT76 PCI driver checks for the wakeup-source property on the device's
device tree node to enable Wake-on-WLAN. By replacing the wifi@0 PCI device
node with an OF graph port node, the PCI device loses this property.

Additionally, because the port node lacks a reg mapping, the PCI core won't
associate it with the PCI device, leaving the PCI device's of_node as NULL.

Does this board still expect Wake-on-WLAN to be enabled by default for the
Wi-Fi card during system suspend and resume flows?

> +		port {
> +			pcie1_ep: endpoint {
> +				remote-endpoint = <&wifi_ep>;
> +			};
>  		};
>  	};
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709095726.704448-1-wenst@chromium.org?part=13