Re: [PATCH v2 2/4] arm64: dts: imx8qm-ss-audio: add spdif1 node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The new clock controller node `spdif1_lpcg` is incorrectly marked with `status = "disabled";`. In i.MX8 device trees, LPCG (Local Peripheral Clock Gate) nodes provide clocks to hardware blocks and are intended to be enabled by default at the SoC level, as the clock framework automatically manages them. Setting `status = "disabled";` means the device node will not be instantiated by the OF core, and its platform driver (`imx8qxp-lpcg-clk`) will not probe. Consequently, when a board file enables `spdif1` (using `&spdif1 { status = "okay"; };`), the `spdif1` driver will fail to probe with a persistent `-EPROBE_DEFER` error because its required clock provider (`spdif1_lpcg`) is unavailable.
--

--- Patch [2]: [PATCH v2 2/4] arm64: dts: imx8qm-ss-audio: add spdif1 node ---
commit 5e80d17ca35f0e8c498b103cd29fc869f77a9125
Author: Frank Li <Frank.Li@nxp.com>
arm64: dts: imx8qm-ss-audio: add spdif1 node

This commit adds the spdif1 audio node and its corresponding local peripheral
clock gate (LPCG) node to the imx8qm-ss-audio device tree.

> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi
> --- a/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi
[ ... ]
> @@ -109,6 +134,19 @@ sai5: sai@59090000 {
>  		status = "disabled";
>  	};
>  
> +	spdif1_lpcg: clock-controller@59430000 {
> +		compatible = "fsl,imx8qxp-lpcg";
> +		reg = <0x59430000 0x10000>;
> +		#clock-cells = <1>;
> +		clocks = <&acm IMX_ADMA_ACM_SPDIF1_TX_CLK_SEL>,
> +			 <&audio_ipg_clk>;
> +		clock-indices = <IMX_LPCG_CLK_5>, <IMX_LPCG_CLK_4>;
> +		clock-output-names = "spdif1_lpcg_tx_clk",
> +				     "spdif1_lpcg_gclkw";
> +		power-domains = <&pd IMX_SC_R_SPDIF_1>;
> +		status = "disabled";

[Severity: Medium]
Will this cause a persistent probe deferral for spdif1?

Since LPCG nodes provide clocks to hardware blocks, they are typically enabled
by default at the SoC level so the clock framework can manage them. Setting
the status to disabled here means the clock provider won't probe unless a
board file explicitly enables it.

If a board file only enables spdif1, won't it fail to probe with -EPROBE_DEFER
because its required clock provider is unavailable?

> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-qm_dts-v2-0-3ebcce82bb79@nxp.com?part=2