Re: [PATCH 3/4] serial: 8250: map UAPI port type to internal enum

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] The new documentation guidelines encourage a split-brain ID registry that will cause integer collisions between internal 8250 port types and global UAPI port types.
--

--- Patch [3]: [PATCH 3/4] serial: 8250: map UAPI port type to internal enum ---
commit d2ffed5bdc0925967ba25a551f7c1657761a9cab
Author: Christian Marangi <ansuelsmth@gmail.com>

serial: 8250: map UAPI port type to internal enum

This commit maps the UAPI port types to an internal enum in the 8250 driver.
It creates a dedicated enum in 8250.h with all current UAPI values and documents
how new indexes should be defined. It also renames definitions in 8250_port.c
with a new UART_ prefix.

> diff --git a/drivers/tty/serial/8250/8250.h b/drivers/tty/serial/8250/8250.h
> --- a/drivers/tty/serial/8250/8250.h
> +++ b/drivers/tty/serial/8250/8250.h
> @@ -73,6 +73,128 @@ struct serial8250_config {
>  	unsigned int	flags;
>  };
>  
> +/*
> + * The uart_config[] array index is referenced and defined from index
> + * in uapi/linux/serial.h and uapi/linux/serial_core.h.
> + *
> + * This was old practice and for anything that doesn't need to support
> + * userspace, new type should be limited and added only HERE.
> + *
> + * Any UART port that requires userspace support, should define the
> + * dedicated index in the UAPI header and reference it when added
> + * to this enum table.
> + */
> +enum uart_port_type {

[Severity: High]
Does this new documentation encourage a split-brain ID registry that could
cause integer collisions between internal 8250 port types and global UAPI
port types?

If a developer follows this documentation and defines a new internal port type
at the end of enum uart_port_type (e.g., getting value 124), what happens if
another subsystem concurrently adds a port to <uapi/linux/serial_core.h> that
also receives value 124?

Since the port->type field is a globally shared namespace across all serial
drivers, driver-local enum values that are not offset into a disjoint range
might collide with new UAPI additions. This could manifest as compile-time
errors when the uart_config[] array is populated, or runtime ABI
misidentification by userspace tools if setserial treats an internal 8250
port as a completely different architecture's port.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709205656.319531-1-ansuelsmth@gmail.com?part=3