Re: [PATCH v15 4/6] pinctrl: add NXP MC33978/MC34978 pinctrl driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing getter support for PIN_CONFIG_DRIVE_STRENGTH_UA breaks pinconf readback symmetry.
--

--- Patch [4]: [PATCH v15 4/6] pinctrl: add NXP MC33978/MC34978 pinctrl driver ---
commit ac0b5b5ec87f6510c16dfd82ea1f8febfb16aa81
Author: David Jander <david@protonic.nl>
Subject: pinctrl: add NXP MC33978/MC34978 pinctrl driver

This commit adds a new pinctrl and GPIO driver for the NXP MC33978/MC34978
Multiple Switch Detection Interface (MSDI) devices. It provides GPIO read/write
access, emulated outputs, and interrupt routing by exposing the 22 mechanical
switch detection inputs as standard GPIOs.

> diff --git a/drivers/pinctrl/pinctrl-mc33978.c b/drivers/pinctrl/pinctrl-mc33978.c
> new file mode 100644
> index 0000000000000..4a7ea1bed233c
> --- /dev/null
> +++ b/drivers/pinctrl/pinctrl-mc33978.c

[ ... ]

> +static int mc33978_pinconf_get(struct pinctrl_dev *pctldev, unsigned int pin,
> +			       unsigned long *config)
> +{

[ ... ]

> +	case PIN_CONFIG_DRIVE_STRENGTH:
> +		ret = mc33978_get_ds(mpc, pin, &data);
> +		if (ret)
> +			return ret;
> +		arg = data;
> +		break;

[Severity: Medium]
Will this cause debugfs read failures for microamp configurations?

The setter mc33978_pinconf_set() explicitly handles
PIN_CONFIG_DRIVE_STRENGTH_UA, but it is missing here in the getter.
Should PIN_CONFIG_DRIVE_STRENGTH_UA be supported here to maintain readback
symmetry?

> +	default:
> +		/*
> +		 * Ignore checkpatch warning: the pinctrl core specifically
> +		 * expects -ENOTSUPP to silently skip unsupported generic
> +		 * parameters. Using -EOPNOTSUPP causes debugfs read failures.
> +		 */
> +		return -ENOTSUPP;
> +	}
> +
> +	*config = pinconf_to_config_packed(param, arg);
> +
> +	return 0;
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260710101358.2606941-1-o.rempel@pengutronix.de?part=4