[PATCH] dt-bindings: soc: qcom,wcnss: Drop redundant $ref of firmware-name property

[PATCH] dt-bindings: soc: qcom,wcnss: Drop redundant $ref of firmware-name property

[Krzysztof Kozlowski]

The DT schema core defines the type ($ref) of 'firmware-name' property
as string-array, so individual schemas do not need to.  They also should
not redefine it to a single string, but instead just set number of
expected firmware names.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
index 72a7f8cb09ba..eb76f222d681 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
@@ -19,7 +19,7 @@ properties:
     const: qcom,wcnss
 
   firmware-name:
-    $ref: /schemas/types.yaml#/definitions/string
+    maxItems: 1
     default: wlan/prima/WCNSS_qcom_wlan_nv.bin
     description:
       Relative firmware image path for the WLAN NV blob.
-- 
2.53.0

Re: [PATCH] dt-bindings: soc: qcom,wcnss: Drop redundant $ref of firmware-name property

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Schema validation error: `default` value for `firmware-name` is a scalar string but should be a string array.
--

--- Patch [1]: [PATCH] dt-bindings: soc: qcom,wcnss: Drop redundant $ref of firmware-name property ---
commit ee3e2676da46575844622ab43164871fd3c8d4ab
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dt-bindings: soc: qcom,wcnss: Drop redundant $ref of firmware-name property

This commit removes the explicit string reference for the firmware-name
property and replaces it with maxItems: 1, implicitly adopting the
string-array type from the core schema.

> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,wcnss.yaml
> @@ -19,7 +19,7 @@ properties:
>      const: qcom,wcnss
>  
>    firmware-name:
> -    $ref: /schemas/types.yaml#/definitions/string
> +    maxItems: 1
>      default: wlan/prima/WCNSS_qcom_wlan_nv.bin

[Severity: Low]
Will this cause dt_binding_check to fail? Since the property type is now
implicitly a string-array due to maxItems, should the default value be
updated to an array format like [ wlan/prima/WCNSS_qcom_wlan_nv.bin ] to
avoid a JSON schema validation error?

>      description:
>        Relative firmware image path for the WLAN NV blob.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260712145654.126171-2-krzysztof.kozlowski@oss.qualcomm.com?part=1

Re: [PATCH] dt-bindings: soc: qcom,wcnss: Drop redundant $ref of firmware-name property

[Krzysztof Kozlowski]

On 12/07/2026 17:07, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Schema validation error: `default` value for `firmware-name` is a scalar string but should be a string array.
> --


Validation passes, but I can make it for correctness:
default: [ wlan/prima/WCNSS_qcom_wlan_nv.bin ]

Best regards,
Krzysztof