Devicetree
 help / color / mirror / Atom feed
* [PATCH RESEND v3] dt-bindings: leds: Add default-intensity property
@ 2026-07-13  8:50 Jonas Rebmann
  2026-07-13  8:55 ` sashiko-bot
  2026-07-13 16:17 ` Conor Dooley
  0 siblings, 2 replies; 3+ messages in thread
From: Jonas Rebmann @ 2026-07-13  8:50 UTC (permalink / raw)
  To: Lee Jones, Pavel Machek, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Jacek Anaszewski, Sven Schwermer
  Cc: Pavel Machek, linux-leds, devicetree, linux-kernel, kernel,
	Jonas Rebmann

Document the default-intensity property to set a default color on
multicolor LEDs.

Update pwm-multicolor to support it and update the example to turn the
LED red on boot.

Signed-off-by: Jonas Rebmann <jre@pengutronix.de>
---
Changes in v3:
- make default-intensity property description more generic and less
  redundant (Thanks, Conor)
- Drop applied patch that introduces the property (Thanks, Lee)
- Link to v2: https://patch.msgid.link/20260605-multicolor-default-v2-0-ed07271df6b0@pengutronix.de

Changes in v2:
- dt-bindings: Use correct property name in example
- dt-bindings: Add missing word in property description
- Link to v1: https://patch.msgid.link/20260604-multicolor-default-v1-0-b07bff431537@pengutronix.de
---
 Documentation/devicetree/bindings/leds/common.yaml             | 10 ++++++++++
 .../devicetree/bindings/leds/leds-pwm-multicolor.yaml          |  4 ++++
 2 files changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index f4e44b33f56d..f2f479b565a9 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -73,6 +73,16 @@ properties:
       - keep
     default: off
 
+  default-intensity:
+    description:
+      The initial intensity of the LED color component. As the intensity of
+      each sub-LED is multiplied with the overall brightness, without this
+      property on a sub-LED, it may effectively be initialized at minimum
+      brightness regardless of its linux,default-trigger and default-brightness
+      properties.
+    $ref: /schemas/types.yaml#/definitions/uint32
+    default: 0
+
   linux,default-trigger:
     description:
       This parameter, if present, is a string defining the trigger assigned to
diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
index a31a202afe5c..7bf687c89411 100644
--- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
@@ -45,6 +45,8 @@ properties:
 
           color: true
 
+          default-intensity: true
+
         required:
           - pwms
           - color
@@ -63,12 +65,14 @@ examples:
 
         multi-led {
             color = <LED_COLOR_ID_RGB>;
+            linux,default-trigger = "default-on";
             function = LED_FUNCTION_INDICATOR;
             max-brightness = <65535>;
 
             led-red {
                 pwms = <&pwm1 0 1000000>;
                 color = <LED_COLOR_ID_RED>;
+                default-intensity = <65535>;
             };
 
             led-green {

---
base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482
change-id: 20260604-multicolor-default-11e3becde05a

Best regards,
--
Jonas Rebmann <jre@pengutronix.de>
-- 
Jonas Rebmann <jre@pengutronix.de>


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND v3] dt-bindings: leds: Add default-intensity property
  2026-07-13  8:50 [PATCH RESEND v3] dt-bindings: leds: Add default-intensity property Jonas Rebmann
@ 2026-07-13  8:55 ` sashiko-bot
  2026-07-13 16:17 ` Conor Dooley
  1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-07-13  8:55 UTC (permalink / raw)
  To: Jonas Rebmann; +Cc: linux-leds, lee, devicetree, robh, conor+dt

> Document the default-intensity property to set a default color on
> multicolor LEDs.
> 
> Update pwm-multicolor to support it and update the example to turn the
> LED red on boot.
> 
> Signed-off-by: Jonas Rebmann <jre@pengutronix.de>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713-multicolor-default-v3-1-fb43f3f789cf@pengutronix.de?part=1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND v3] dt-bindings: leds: Add default-intensity property
  2026-07-13  8:50 [PATCH RESEND v3] dt-bindings: leds: Add default-intensity property Jonas Rebmann
  2026-07-13  8:55 ` sashiko-bot
@ 2026-07-13 16:17 ` Conor Dooley
  1 sibling, 0 replies; 3+ messages in thread
From: Conor Dooley @ 2026-07-13 16:17 UTC (permalink / raw)
  To: Jonas Rebmann
  Cc: Lee Jones, Pavel Machek, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Jacek Anaszewski, Sven Schwermer, Pavel Machek,
	linux-leds, devicetree, linux-kernel, kernel

[-- Attachment #1: Type: text/plain, Size: 75 bytes --]

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-07-13 16:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-13  8:50 [PATCH RESEND v3] dt-bindings: leds: Add default-intensity property Jonas Rebmann
2026-07-13  8:55 ` sashiko-bot
2026-07-13 16:17 ` Conor Dooley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox