Re: [PATCH v5 1/6] dt-bindings: media: qcom: Add Shikra CAMSS compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The schema uses a global `oneOf` for `iommus` instead of conditionally restricting the number of items per compatible string, allowing invalid configurations to silently pass validation.
--

--- Patch [1]: [PATCH v5 1/6] dt-bindings: media: qcom: Add Shikra CAMSS compatible ---
commit fc0a6e2efaafe1932112e71e5a72e67dfe8ffb3f
Author: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>

dt-bindings: media: qcom: Add Shikra CAMSS compatible

This commit documents the Shikra Camera Subsystem IP, using qcm2290-camss
as a fallback. It updates the compatible string list and changes the iommus
property to allow either 1 or 4 items depending on whether the CDM and OPE
blocks are present.

> diff --git a/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml b/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml
> index 391d0f6f67ef5..490a7f3a8c5ff 100644
> --- a/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,qcm2290-camss.yaml

[ ... ]

> @@ -76,7 +80,14 @@ properties:
>        - const: sf_mnoc
>  
>    iommus:
> -    maxItems: 4
> +    oneOf:
> +      - items:
> +          - description: S1 HLOS VFE non-protected (VFE only)
> +      - items:
> +          - description: S1 HLOS VFE non-protected
> +          - description: S1 HLOS CDM non-protected
> +          - description: S1 HLOS OPE read non-protected
> +          - description: S1 HLOS OPE write non-protected

[Severity: Medium]
By using a global oneOf for the iommus property, doesn't this allow invalid
configurations to pass schema validation?

Without an allOf block containing if-then conditional constraints tying the
specific compatible string to its corresponding number of IOMMUs, a device
tree configuring a QCM2290 device with only 1 IOMMU, or a Shikra device with
4 IOMMUs, will silently pass validation.

Should this constraint be enforced conditionally based on the compatible
string?

>  
>    power-domains:
>      items:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713-shikra-camss-review-v5-0-db53be15dc4f@oss.qualcomm.com?part=1