Re: [PATCH v5 2/6] arm64: dts: qcom: shikra: Add CAMSS node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `camss@5c11000` node is placed out of order in `shikra.dtsi`, violating device tree sorting rules.
--

--- Patch [2]: [PATCH v5 2/6] arm64: dts: qcom: shikra: Add CAMSS node ---
commit 3b1defa09283750cdb86a9b19398c488f2a5fdb0
Author: Nihal Kumar Gupta <nihal.gupta@oss.qualcomm.com>

arm64: dts: qcom: shikra: Add CAMSS node
    
This patch adds the Camera Subsystem (CAMSS) node for Shikra. It specifies
that Shikra shares the same IP as QCM2290 but drops CDM and OPE blocks,
requiring only a single IOMMU context bank.

> diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi
> index 4e5bc9e17c8ed..6335caca32980 100644
> --- a/arch/arm64/boot/dts/qcom/shikra.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi
> @@ -604,6 +604,106 @@ opp-384000000 {
>  			};
>  		};
>  
> +		camss: camss@5c11000 {
> +			compatible = "qcom,shikra-camss", "qcom,qcm2290-camss";

[Severity: Low]
Could this node be placed out of order? 

Device tree node unit-addresses are generally sorted numerically, but here 
camss@5c11000 is placed before the geniqup@4ac0000 node, which breaks the 
numerical sorting under the soc node.

[ ... ]

> +		};
> +
>  		qupv3_0: geniqup@4ac0000 {
>  			compatible = "qcom,geni-se-qup";
>  			reg = <0x0 0x04ac0000 0x0 0x2000>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713-shikra-camss-review-v5-0-db53be15dc4f@oss.qualcomm.com?part=2