Re: [PATCH v9 2/7] dt-bindings: clock: qcom,glymur-tcsr: Add mahua support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Consumer supply properties for Mahua are incorrectly named after the external provider regulators rather than the consumer's internal hardware block.
--

--- Patch [2]: [PATCH v9 2/7] dt-bindings: clock: qcom,glymur-tcsr: Add mahua support ---
commit 6be182ccdfcaa98dff1b1eb3997c0618159a4ce8
Author: Qiang Yu <qiang.yu@oss.qualcomm.com>

dt-bindings: clock: qcom,glymur-tcsr: Add mahua support

This commit adds device tree binding support for the qcom,mahua-tcsr
hardware variant. It notes that Mahua features a single QREF block fed
by refgen4, which is in turn supplied by the vdda-refgen3-1p2 and
vdda-refgen3-0p9 regulators.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml b/Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml
> --- a/Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml

[ ... ]

> @@ -82,6 +83,25 @@ allOf:
>          - vdda-refgen3-1p2-supply
>          - vdda-refgen4-0p9-supply
>          - vdda-refgen4-1p2-supply
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: qcom,mahua-tcsr
> +    then:
> +      required:
> +        - vdda-qrefrpt0-0p9-supply
> +        - vdda-qrefrpt1-0p9-supply
> +        - vdda-qrefrpt2-0p9-supply
> +        - vdda-qrefrpt3-0p9-supply
> +        - vdda-qrefrpt4-0p9-supply
> +        - vdda-qrefrpt5-0p9-supply
> +        - vdda-qrefrx1-0p9-supply
> +        - vdda-qrefrx2-0p9-supply
> +        - vdda-qrefrx3-0p9-supply
> +        - vdda-qreftx1-0p9-supply
> +        - vdda-refgen3-0p9-supply
> +        - vdda-refgen3-1p2-supply

[Severity: Medium]
Should these supply properties be named after the consumer's internal
hardware block (refgen4) rather than the external provider regulators?

The commit message notes that Mahua has a single QREF block fed by refgen4
only. Since device tree supply properties are typically named after the
consumer's input pins or blocks rather than the board-level supply rails,
would it be more appropriate to name these vdda-refgen4-0p9-supply and
vdda-refgen4-1p2-supply to keep the ABI independent of the external
regulator names?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713-tcsr_qref_0714-v9-0-373670ab15f9@oss.qualcomm.com?part=2