Re: [PATCH v9 1/7] dt-bindings: clock: qcom: Move glymur TCSR to own binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added qcom,glymur-tcsr.yaml binding marks 17 `vdda-qref*` supply properties as unconditionally required, but existing device trees do not provide them, causing a `dtbs_check` validation regression.
--

--- Patch [1]: [PATCH v9 1/7] dt-bindings: clock: qcom: Move glymur TCSR to own binding ---
commit 6bffb0197809346112dba264dc91035d8e1ed982
Author: Qiang Yu <qiang.yu@oss.qualcomm.com>

dt-bindings: clock: qcom: Move glymur TCSR to own binding

This commit extracts the Glymur TCSR block into its own dedicated YAML binding
file and documents the supply properties required by the QREF block. It uses
an allOf conditional block to enforce these supplies for the qcom,glymur-tcsr
compatible string.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml b/Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml
> new file mode 100644
> index 0000000000000..ec89feff89e4e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,glymur-tcsr.yaml
[ ... ]
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: qcom,glymur-tcsr
> +    then:
> +      required:
> +        - vdda-qrefrpt0-0p9-supply
> +        - vdda-qrefrpt1-0p9-supply

[Severity: Medium]
Does this cause a dtbs_check validation regression for existing platforms?

By marking these 17 vdda-qref* supply properties as unconditionally required
in the allOf block, validation will fail for existing device trees (such as
arch/arm64/boot/dts/qcom/glymur.dtsi) that use the qcom,glymur-tcsr
compatible string but do not yet provide these supplies.

Would it be better to introduce these properties as optional first, or ensure
the corresponding device tree updates are included in the same patch series
to prevent breaking schema validation?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713-tcsr_qref_0714-v9-0-373670ab15f9@oss.qualcomm.com?part=1