Devicetree
 help / color / mirror / Atom feed
* [PATCH v4] dt-bindings: leds: Add default-intensity property
@ 2026-07-14  7:35 Jonas Rebmann
  2026-07-14  7:40 ` sashiko-bot
  0 siblings, 1 reply; 2+ messages in thread
From: Jonas Rebmann @ 2026-07-14  7:35 UTC (permalink / raw)
  To: Lee Jones, Pavel Machek, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Jacek Anaszewski, Sven Schwermer
  Cc: Pavel Machek, linux-leds, devicetree, linux-kernel, kernel,
	Stefan Wahren, Conor Dooley, Jonas Rebmann

Document the default-intensity property to set a default color on
multicolor LEDs.

Update pwm-multicolor to support it and update the example to turn the
LED red on boot.

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Signed-off-by: Jonas Rebmann <jre@pengutronix.de>
---
Changes in v4:
- Move default to leds-pwm-multicolor.yaml as other drivers have other
  defaults (Thanks, Conor)
- Move definition of default-intensity property next to default-brightness
- Slighly improve description
- Link to v3: https://patch.msgid.link/20260630-multicolor-default-v3-1-24c5170ca3cd@pengutronix.de

Changes in v3:
- make default-intensity property description more generic and less
  redundant (Thanks, Conor)
- Drop applied patch that introduces the property (Thanks, Lee)
- Link to v2: https://patch.msgid.link/20260605-multicolor-default-v2-0-ed07271df6b0@pengutronix.de

Changes in v2:
- dt-bindings: Use correct property name in example
- dt-bindings: Add missing word in property description
- Link to v1: https://patch.msgid.link/20260604-multicolor-default-v1-0-b07bff431537@pengutronix.de
---
 Documentation/devicetree/bindings/leds/common.yaml              | 9 +++++++++
 Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml | 5 +++++
 2 files changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index f4e44b33f56d..3e6f913070b0 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -179,6 +179,15 @@ properties:
       initialization. If the option is not set then max brightness is used.
     $ref: /schemas/types.yaml#/definitions/uint32
 
+  default-intensity:
+    description:
+      The initial intensity of the LED color component. As the intensity of
+      each sub-LED is multiplied by the overall brightness, without this
+      property on a sub-LED, it may effectively be initialized at a brightness
+      of 0 regardless of its linux,default-trigger and default-brightness
+      properties.
+    $ref: /schemas/types.yaml#/definitions/uint32
+
   panic-indicator:
     description:
       This property specifies that the LED should be used, if at all possible,
diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
index a31a202afe5c..08e28c5f08a8 100644
--- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
@@ -45,6 +45,9 @@ properties:
 
           color: true
 
+          default-intensity:
+            default: 0
+
         required:
           - pwms
           - color
@@ -63,12 +66,14 @@ examples:
 
         multi-led {
             color = <LED_COLOR_ID_RGB>;
+            linux,default-trigger = "default-on";
             function = LED_FUNCTION_INDICATOR;
             max-brightness = <65535>;
 
             led-red {
                 pwms = <&pwm1 0 1000000>;
                 color = <LED_COLOR_ID_RED>;
+                default-intensity = <65535>;
             };
 
             led-green {

---
base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482
change-id: 20260604-multicolor-default-11e3becde05a

Best regards,
--  
Jonas Rebmann <jre@pengutronix.de>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v4] dt-bindings: leds: Add default-intensity property
  2026-07-14  7:35 [PATCH v4] dt-bindings: leds: Add default-intensity property Jonas Rebmann
@ 2026-07-14  7:40 ` sashiko-bot
  0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-07-14  7:40 UTC (permalink / raw)
  To: Jonas Rebmann; +Cc: lee, linux-leds, conor+dt, devicetree, robh

> Document the default-intensity property to set a default color on
> multicolor LEDs.
> 
> Update pwm-multicolor to support it and update the example to turn the
> LED red on boot.
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Jonas Rebmann <jre@pengutronix.de>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260714-multicolor-default-v4-1-c2335b32bc39@pengutronix.de?part=1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-07-14  7:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-14  7:35 [PATCH v4] dt-bindings: leds: Add default-intensity property Jonas Rebmann
2026-07-14  7:40 ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox