Re: [PATCH 2/3] arm64: dts: qcom: eliza-mtp: Enable CDSP remoteproc

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `remoteproc_cdsp` node is missing the `glink-edge` subnode required for IPC.
--

--- Patch [2]: [PATCH 2/3] arm64: dts: qcom: eliza-mtp: Enable CDSP remoteproc ---
commit 5af49a73d9e2d56636adad16779d928f64bfc0a3
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

arm64: dts: qcom: eliza-mtp: Enable CDSP remoteproc

This commit enables the CDSP remoteproc node on the Eliza MTP. It provides 
the required firmware names and sets the status to okay to bring the DSP out 
of reset.

> diff --git a/arch/arm64/boot/dts/qcom/eliza-mtp.dts b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
> index a7d6f9d52ef31..7de4ee3935e63 100644
> --- a/arch/arm64/boot/dts/qcom/eliza-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
> @@ -484,6 +484,13 @@ &remoteproc_adsp {
>  	status = "okay";
>  };
>  
> +&remoteproc_cdsp {
> +	firmware-name = "qcom/eliza/cdsp.mbn",
> +			"qcom/eliza/cdsp_dtb.mbn";
> +
> +	status = "okay";
> +};

[Severity: Medium]
Is this missing the glink-edge subnode required for IPC?

Looking at the base device tree definition in 
arch/arm64/boot/dts/qcom/eliza.dtsi, the remoteproc_cdsp node is defined 
without a glink-edge child node:

	remoteproc_cdsp: remoteproc@32300000 {
		compatible = "qcom,eliza-cdsp-pas";
...
		qcom,smem-states = <&smp2p_cdsp_out 0>;
		qcom,smem-state-names = "stop";

		status = "disabled";
	};

Without this subnode, qcom_glink_smem won't be instantiated for the CDSP. 
Will this leave the DSP functionally isolated since the host cannot establish 
RPMSG IPC channels (like fastrpcglink-apps-dsp) to perform compute offloading?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260714-dts-qcom-eliza-add-cdsp-v1-0-525e757a23b0@oss.qualcomm.com?part=2