[PATCH 0/3] arm64: dts: qcom: eliza: Add CDSP support and enable it on MTP and CQS SoM

Devicetree
 help / color / mirror / Atom feed

* [PATCH 0/3] arm64: dts: qcom: eliza: Add CDSP support and enable it on MTP and CQS SoM
@ 2026-07-14 13:06 Abel Vesa
  2026-07-14 13:06 ` [PATCH 1/3] arm64: dts: qcom: eliza: Describe the CDSP remoteproc Abel Vesa
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Abel Vesa @ 2026-07-14 13:06 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Abel Vesa

Describe the CDSP node and the related SMP2P, then enable the CDSP on
both the MTP and CQS SoM.

Driver support and bindings update are here:
https://lore.kernel.org/all/20260714-remoteproc-eliza-cdsp-v1-0-32eb7a1f2c59@oss.qualcomm.com/

Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
Abel Vesa (3):
      arm64: dts: qcom: eliza: Describe the CDSP remoteproc
      arm64: dts: qcom: eliza-mtp: Enable CDSP remoteproc
      arm64: dts: qcom: eliza-cqs-som: Enable CDSP remoteproc

 arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi |  7 ++++
 arch/arm64/boot/dts/qcom/eliza-mtp.dts      |  7 ++++
 arch/arm64/boot/dts/qcom/eliza.dtsi         | 64 +++++++++++++++++++++++++++++
 3 files changed, 78 insertions(+)
---
base-commit: 49362394dad7df66c274c867a271394c10ca2bb8
change-id: 20260714-dts-qcom-eliza-add-cdsp-0288fd79c8c2

Best regards,
--  
Abel Vesa <abel.vesa@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/3] arm64: dts: qcom: eliza: Describe the CDSP remoteproc
  2026-07-14 13:06 [PATCH 0/3] arm64: dts: qcom: eliza: Add CDSP support and enable it on MTP and CQS SoM Abel Vesa
@ 2026-07-14 13:06 ` Abel Vesa
  2026-07-14 13:06 ` [PATCH 2/3] arm64: dts: qcom: eliza-mtp: Enable " Abel Vesa
  2026-07-14 13:06 ` [PATCH 3/3] arm64: dts: qcom: eliza-cqs-som: " Abel Vesa
  2 siblings, 0 replies; 5+ messages in thread
From: Abel Vesa @ 2026-07-14 13:06 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Abel Vesa

Describe the CDSP remoteproc along with the related SMP2P.

Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/eliza.dtsi | 64 +++++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/eliza.dtsi b/arch/arm64/boot/dts/qcom/eliza.dtsi
index 357e8066c176..0c6fdfc5a4cc 100644
--- a/arch/arm64/boot/dts/qcom/eliza.dtsi
+++ b/arch/arm64/boot/dts/qcom/eliza.dtsi
@@ -626,6 +626,30 @@ smp2p_adsp_in: slave-kernel {
 		};
 	};
 
+	smp2p-cdsp {
+		compatible = "qcom,smp2p";
+		qcom,smem = <94>, <432>;
+		interrupts-extended = <&ipcc IPCC_CLIENT_CDSP
+					     IPCC_MPROC_SIGNAL_SMP2P
+					     IRQ_TYPE_EDGE_RISING>;
+		mboxes = <&ipcc IPCC_CLIENT_CDSP
+				IPCC_MPROC_SIGNAL_SMP2P>;
+
+		qcom,local-pid = <0>;
+		qcom,remote-pid = <5>;
+
+		smp2p_cdsp_out: master-kernel {
+			qcom,entry-name = "master-kernel";
+			#qcom,smem-state-cells = <1>;
+		};
+
+		smp2p_cdsp_in: slave-kernel {
+			qcom,entry-name = "slave-kernel";
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+	};
+
 	soc: soc@0 {
 		compatible = "simple-bus";
 
@@ -3737,6 +3761,46 @@ nsp_noc: interconnect@320c0000 {
 			qcom,bcm-voters = <&apps_bcm_voter>;
 			#interconnect-cells = <2>;
 		};
+
+		remoteproc_cdsp: remoteproc@32300000 {
+			compatible = "qcom,eliza-cdsp-pas";
+			reg = <0x0 0x32300000 0x0 0x10000>;
+
+			interrupts-extended = <&intc GIC_SPI 578 IRQ_TYPE_EDGE_RISING>,
+					      <&smp2p_cdsp_in 0 IRQ_TYPE_EDGE_RISING>,
+					      <&smp2p_cdsp_in 1 IRQ_TYPE_EDGE_RISING>,
+					      <&smp2p_cdsp_in 2 IRQ_TYPE_EDGE_RISING>,
+					      <&smp2p_cdsp_in 3 IRQ_TYPE_EDGE_RISING>,
+					      <&smp2p_cdsp_in 7 IRQ_TYPE_EDGE_RISING>;
+			interrupt-names = "wdog",
+					  "fatal",
+					  "ready",
+					  "handover",
+					  "stop-ack",
+					  "shutdown-ack";
+
+			clocks = <&rpmhcc RPMH_CXO_CLK>;
+			clock-names = "xo";
+
+			power-domains = <&rpmhpd RPMHPD_CX>,
+					<&rpmhpd RPMHPD_MX>,
+					<&rpmhpd RPMHPD_NSP>;
+			power-domain-names = "cx",
+					     "mx",
+					     "nsp";
+
+			interconnects = <&nsp_noc MASTER_CDSP_PROC QCOM_ICC_TAG_ALWAYS
+					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>;
+
+			memory-region = <&cdsp_mem>, <&q6_cdsp_dtb_mem>, <&global_sync_mem>;
+
+			qcom,qmp = <&aoss_qmp>;
+
+			qcom,smem-states = <&smp2p_cdsp_out 0>;
+			qcom,smem-state-names = "stop";
+
+			status = "disabled";
+		};
 	};
 
 	thermal-zones {

-- 
2.54.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/3] arm64: dts: qcom: eliza-mtp: Enable CDSP remoteproc
  2026-07-14 13:06 [PATCH 0/3] arm64: dts: qcom: eliza: Add CDSP support and enable it on MTP and CQS SoM Abel Vesa
  2026-07-14 13:06 ` [PATCH 1/3] arm64: dts: qcom: eliza: Describe the CDSP remoteproc Abel Vesa
@ 2026-07-14 13:06 ` Abel Vesa
  2026-07-14 13:49   ` sashiko-bot
  2026-07-14 13:06 ` [PATCH 3/3] arm64: dts: qcom: eliza-cqs-som: " Abel Vesa
  2 siblings, 1 reply; 5+ messages in thread
From: Abel Vesa @ 2026-07-14 13:06 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Abel Vesa

Enable the CDSP remoteproc node on the Eliza MTP by providing the firmware
names and marking the node as available.

Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/eliza-mtp.dts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/eliza-mtp.dts b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
index a7d6f9d52ef3..7de4ee3935e6 100644
--- a/arch/arm64/boot/dts/qcom/eliza-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
@@ -484,6 +484,13 @@ &remoteproc_adsp {
 	status = "okay";
 };
 
+&remoteproc_cdsp {
+	firmware-name = "qcom/eliza/cdsp.mbn",
+			"qcom/eliza/cdsp_dtb.mbn";
+
+	status = "okay";
+};
+
 &tlmm {
 	gpio-reserved-ranges = <20 4>,   /* NFC SPI */
 			       <111 2>,  /* WCN UART1 */

-- 
2.54.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/3] arm64: dts: qcom: eliza-mtp: Enable CDSP remoteproc
  2026-07-14 13:06 ` [PATCH 2/3] arm64: dts: qcom: eliza-mtp: Enable " Abel Vesa
@ 2026-07-14 13:49   ` sashiko-bot
  0 siblings, 0 replies; 5+ messages in thread
From: sashiko-bot @ 2026-07-14 13:49 UTC (permalink / raw)
  To: Abel Vesa; +Cc: devicetree, robh, conor+dt

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `remoteproc_cdsp` node is missing the `glink-edge` subnode required for IPC.
--

--- Patch [2]: [PATCH 2/3] arm64: dts: qcom: eliza-mtp: Enable CDSP remoteproc ---
commit 5af49a73d9e2d56636adad16779d928f64bfc0a3
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

arm64: dts: qcom: eliza-mtp: Enable CDSP remoteproc

This commit enables the CDSP remoteproc node on the Eliza MTP. It provides 
the required firmware names and sets the status to okay to bring the DSP out 
of reset.

> diff --git a/arch/arm64/boot/dts/qcom/eliza-mtp.dts b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
> index a7d6f9d52ef31..7de4ee3935e63 100644
> --- a/arch/arm64/boot/dts/qcom/eliza-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/eliza-mtp.dts
> @@ -484,6 +484,13 @@ &remoteproc_adsp {
>  	status = "okay";
>  };
>  
> +&remoteproc_cdsp {
> +	firmware-name = "qcom/eliza/cdsp.mbn",
> +			"qcom/eliza/cdsp_dtb.mbn";
> +
> +	status = "okay";
> +};

[Severity: Medium]
Is this missing the glink-edge subnode required for IPC?

Looking at the base device tree definition in 
arch/arm64/boot/dts/qcom/eliza.dtsi, the remoteproc_cdsp node is defined 
without a glink-edge child node:

	remoteproc_cdsp: remoteproc@32300000 {
		compatible = "qcom,eliza-cdsp-pas";
...
		qcom,smem-states = <&smp2p_cdsp_out 0>;
		qcom,smem-state-names = "stop";

		status = "disabled";
	};

Without this subnode, qcom_glink_smem won't be instantiated for the CDSP. 
Will this leave the DSP functionally isolated since the host cannot establish 
RPMSG IPC channels (like fastrpcglink-apps-dsp) to perform compute offloading?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260714-dts-qcom-eliza-add-cdsp-v1-0-525e757a23b0@oss.qualcomm.com?part=2

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 3/3] arm64: dts: qcom: eliza-cqs-som: Enable CDSP remoteproc
  2026-07-14 13:06 [PATCH 0/3] arm64: dts: qcom: eliza: Add CDSP support and enable it on MTP and CQS SoM Abel Vesa
  2026-07-14 13:06 ` [PATCH 1/3] arm64: dts: qcom: eliza: Describe the CDSP remoteproc Abel Vesa
  2026-07-14 13:06 ` [PATCH 2/3] arm64: dts: qcom: eliza-mtp: Enable " Abel Vesa
@ 2026-07-14 13:06 ` Abel Vesa
  2 siblings, 0 replies; 5+ messages in thread
From: Abel Vesa @ 2026-07-14 13:06 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley
  Cc: linux-arm-msm, devicetree, linux-kernel, Abel Vesa

Enable the CDSP remoteproc node on the Eliza CQS SoM by providing the
firmware names and marking the node as available.

Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi b/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
index 318ae3c22351..d31267968cad 100644
--- a/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
+++ b/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
@@ -376,6 +376,13 @@ &remoteproc_adsp {
 	status = "okay";
 };
 
+&remoteproc_cdsp {
+	firmware-name = "qcom/eliza/cdsp.mbn",
+			"qcom/eliza/cdsp_dtb.mbn";
+
+	status = "okay";
+};
+
 &sdhc_1 {
 	vmmc-supply = <&vreg_l12b>;
 	vqmmc-supply = <&vreg_l1d>;

-- 
2.54.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-07-14 13:49 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-14 13:06 [PATCH 0/3] arm64: dts: qcom: eliza: Add CDSP support and enable it on MTP and CQS SoM Abel Vesa
2026-07-14 13:06 ` [PATCH 1/3] arm64: dts: qcom: eliza: Describe the CDSP remoteproc Abel Vesa
2026-07-14 13:06 ` [PATCH 2/3] arm64: dts: qcom: eliza-mtp: Enable " Abel Vesa
2026-07-14 13:49   ` sashiko-bot
2026-07-14 13:06 ` [PATCH 3/3] arm64: dts: qcom: eliza-cqs-som: " Abel Vesa

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox