Re: [PATCH] ARM: dts: renesas: r9a06g032-rzn1d400-eb: enable GPIOs on CN12

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `pinctrl-0` and `pinctrl-names` properties added to the `&gpio2b` subnode will be silently ignored by the kernel because the `snps,dw-apb-gpio` driver does not probe its subnodes as independent platform devices.
--

--- Patch [1]: [PATCH] ARM: dts: renesas: r9a06g032-rzn1d400-eb: enable GPIOs on CN12 ---
commit a17e87c79ff350400e4cf32dff0313dad00fefe9
Author: Wolfram Sang <wsa+renesas@sang-engineering.com>

ARM: dts: renesas: r9a06g032-rzn1d400-eb: enable GPIOs on CN12

This commit adds device tree nodes to enable GPIOs on CN12 for the
r9a06g032-rzn1d400-eb board.

> diff --git a/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-eb.dts b/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-eb.dts
> index ead379988fb1c..7d6ddc91bb2e4 100644
> --- a/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-eb.dts
> +++ b/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-eb.dts
> @@ -57,6 +57,12 @@ &gpio2 {
>  	status = "okay";
>  };
>  
> +&gpio2b {
> +	pinctrl-0 = <&pins_gpio2b>;
> +	pinctrl-names = "default";
> +	status = "okay";
> +};

[Severity: Medium]
Will the pinctrl core actually apply these settings when attached to this
subnode?

The snps,dw-apb-gpio driver iterates over its port subnodes (like gpio2b)
to register gpio_chip interfaces, but it doesn't appear to register these
subnodes as independent platform devices.

Because the driver core only applies pinctrl-0 properties automatically
during probe for fully initialized device instances, this configuration
might be silently ignored by the kernel.

Should these pinctrl properties be moved to the parent &gpio2 node instead
so they are properly applied to the hardware?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260715122341.47838-2-wsa+renesas@sang-engineering.com?part=1